Ignore node_modules effectively #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsmith
reviewed
Dec 4, 2016
| @@ -365,3 +365,41 @@ describe("using codeFilename and ignoreFiles with configBasedir", () => { | |||
| expect(_.get(results[0], [ "_postcssResult", "standaloneIgnored" ])).toBeTruthy() | |||
| }) | |||
| }) | |||
|
|
|||
| describe("file in node_components", () => { | |||
|
Thanks for this @davidtheclark :) |
davidtheclark
force-pushed
the
2149-ignore-node-modules
branch
from
49bc5e5 to
dce664f
Compare
davidtheclark
force-pushed
the
2149-ignore-node-modules
branch
from
5ce4660 to
dce664f
Compare
alexander-akait
approved these changes
Dec 5, 2016
jeddy3
approved these changes
Dec 5, 2016
|
Changlelog:
|
sergesemashko
pushed a commit
to sergesemashko/stylelint
that referenced
this pull request
Mar 3, 2017
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2149.
Managed to reproduce that problem in a test case, and made it pass. I'm not sure if this feature ever worked before in the PostCSS plugin; but we always intended it to, assumed it did, so I'd consider this a bug fix.
cc @simonsmith