Fixed: False positive for custom selectors in selector-pseudo-class-no-unknown #2141
#2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Nov 29, 2016
| @@ -5,6 +5,7 @@ | |||
| - Fixed: `comment-whitespace-inside` no longer complains about `/*!` comments with non-space whitespace (e.g. newlines) ([#2121](https://github.com/stylelint/stylelint/pull/2121)) | |||
| - Fixed: `selector-max-compound-selectors` ignores SCSS nested declarations ([#2102](https://github.com/stylelint/stylelint/pull/2102)) | |||
| - Fixed: regression causing `--stdin-filename` in CLI and `codeFilename` in Node API to error if a non-existent filename is provided ([#2128](https://github.com/stylelint/stylelint/pull/2128)) | |||
| - Fixed: False positive for custom selectors in `selector-pseudo-class-no-unknown` ([#2141](https://github.com/stylelint/stylelint/pull/2141)) | |||
There was a problem hiding this comment.
Don't add lines in changelog, this added after merge PR
| @@ -47,6 +47,9 @@ export default function (actual, options) { | |||
| // Ignore pseudo-elements | |||
| if (value.slice(0, 2) === "::") { return } | |||
|
|
|||
| // Ignore custom selectors | |||
| if (value.slice(0, 3) === ":--") { return } | |||
There was a problem hiding this comment.
Best solution is write util isCustomSelector.js (also add tests) and use it
|
@MoOx thanks for helping 👍 |
MoOx
added a commit
to MoOx/phenomic
that referenced
this pull request
Nov 29, 2016
…no-unknown` Hope I fixed this the right way. Closes #2141
|
PR rebased on master ;) |
MoOx
added a commit
to MoOx/phenomic
that referenced
this pull request
Nov 30, 2016
|
👍 |
|
Added to changelog as:
|
sergesemashko
pushed a commit
to sergesemashko/stylelint
that referenced
this pull request
Mar 3, 2017
romandev0318
pushed a commit
to romandev0318/phenomic
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2141
First commit proves it's failing. 2nd fix it.
Hope I fixed this the right way.
Closes #2141