apply suggestions from code review

stylelint · Oct 29, 2024 · db4ce62 · db4ce62
1 parent d705b4e
commit db4ce62
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 56 deletions.
diff --git a/lib/rules/no-irregular-whitespace/index.cjs b/lib/rules/no-irregular-whitespace/index.cjs
@@ -14,7 +14,6 @@ const getRuleSelector = require('../../utils/getRuleSelector.cjs');
 const report = require('../../utils/report.cjs');
 const ruleMessages = require('../../utils/ruleMessages.cjs');
 const ruleRawsAfterIndex = require('../../utils/ruleRawsAfterIndex.cjs');
-const ruleRawsBetweenIndex = require('../../utils/ruleRawsBetweenIndex.cjs');
 const validateOptions = require('../../utils/validateOptions.cjs');
 
 const ruleName = 'no-irregular-whitespace';
@@ -138,6 +137,14 @@ function oneIndex() {
 	return 1;
 }
 
+/**
+ * @param {import('postcss').Rule} node
+ * @returns {number}
+ */
+function ruleRawsBetweenIndex(node) {
+	return node.selector.length;
+}
+
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;

diff --git a/lib/rules/no-irregular-whitespace/index.mjs b/lib/rules/no-irregular-whitespace/index.mjs
@@ -10,7 +10,6 @@ import getRuleSelector from '../../utils/getRuleSelector.mjs';
 import report from '../../utils/report.mjs';
 import ruleMessages from '../../utils/ruleMessages.mjs';
 import ruleRawsAfterIndex from '../../utils/ruleRawsAfterIndex.mjs';
-import ruleRawsBetweenIndex from '../../utils/ruleRawsBetweenIndex.mjs';
 import validateOptions from '../../utils/validateOptions.mjs';
 
 const ruleName = 'no-irregular-whitespace';
@@ -134,6 +133,14 @@ function oneIndex() {
 	return 1;
 }
 
+/**
+ * @param {import('postcss').Rule} node
+ * @returns {number}
+ */
+function ruleRawsBetweenIndex(node) {
+	return node.selector.length;
+}
+
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;

diff --git a/lib/utils/__tests__/atRuleRawsAfterNameIndex.test.mjs b/lib/utils/__tests__/atRuleRawsAfterNameIndex.test.mjs
@@ -14,7 +14,7 @@ describe('atRuleRawsAfterNameIndex', () => {
 		expect(atRuleRawsAfterNameIndex(atRule(' @media (color) {}'))).toBe(6);
 	});
 
-	it('has a newline before the param', () => {
+	it('has a newline before the @', () => {
 		expect(atRuleRawsAfterNameIndex(atRule('\n@media (color) {}'))).toBe(6);
 	});
 });

diff --git a/lib/utils/__tests__/ruleRawsBetweenIndex.test.mjs b/lib/utils/__tests__/ruleRawsBetweenIndex.test.mjs
diff --git a/lib/utils/ruleRawsBetweenIndex.cjs b/lib/utils/ruleRawsBetweenIndex.cjs
diff --git a/lib/utils/ruleRawsBetweenIndex.mjs b/lib/utils/ruleRawsBetweenIndex.mjs