Fix selector-type-no-unknown false positives for idents in function…

…al pseudo-classes (#8191)
stylelint · Dec 14, 2024 · 6405840 · 6405840
1 parent b988d34
commit 6405840
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 2 deletions.
diff --git a/.changeset/witty-weeks-complain.md b/.changeset/witty-weeks-complain.md
@@ -0,0 +1,5 @@
+---
+"stylelint": patch
+---
+
+Fixed: `selector-type-no-unknown` false positives for idents in functional pseudo-classes
diff --git a/lib/rules/selector-type-no-unknown/__tests__/index.mjs b/lib/rules/selector-type-no-unknown/__tests__/index.mjs
@@ -73,6 +73,9 @@ testRule({
 		{
 			code: '::view-transition-group(qux) {}',
 		},
+		{
+			code: ':active-view-transition-type(foo) {}',
+		},
 		{
 			code: 'input:not(*) {}',
 		},

diff --git a/lib/rules/selector-type-no-unknown/index.cjs b/lib/rules/selector-type-no-unknown/index.cjs
@@ -37,6 +37,14 @@ const IGNORED_PSEUDO_ELEMENTS = new Set([
 	'::view-transition-old',
 ]);
 
+const IGNORED_PSEUDO_CLASSES = new Set([
+	':active-view-transition-type',
+	':dir',
+	':-moz-locale-dir',
+	':state',
+	':lang',
+]);
+
 /** @type {import('stylelint').CoreRules[ruleName]} */
 const rule = (primary, secondaryOptions) => {
 	return (root, result) => {
@@ -89,7 +97,9 @@ const rule = (primary, secondaryOptions) => {
 
 				if (optionsMatches(secondaryOptions, 'ignoreTypes', tagNode.value)) return;
 
-				if (isArgumentOfIgnoredPseudoElement(tagNode)) return;
+				if (isArgumentOfIgnoredPseudoElement(tagNode) || isArgumentOfIgnoredPseudoClass(tagNode)) {
+					return;
+				}
 
 				const tagName = tagNode.value;
 				const tagNameLowerCase = tagName.toLowerCase();
@@ -127,6 +137,13 @@ function isArgumentOfIgnoredPseudoElement(tag) {
 	return selectorParser.isPseudoElement(node) && IGNORED_PSEUDO_ELEMENTS.has(node.value);
 }
 
+/** @param {import('postcss-selector-parser').Tag} tag */
+function isArgumentOfIgnoredPseudoClass(tag) {
+	const node = tag.parent?.parent;
+
+	return selectorParser.isPseudoClass(node) && IGNORED_PSEUDO_CLASSES.has(node.value);
+}
+
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;

diff --git a/lib/rules/selector-type-no-unknown/index.mjs b/lib/rules/selector-type-no-unknown/index.mjs
@@ -34,6 +34,14 @@ const IGNORED_PSEUDO_ELEMENTS = new Set([
 	'::view-transition-old',
 ]);
 
+const IGNORED_PSEUDO_CLASSES = new Set([
+	':active-view-transition-type',
+	':dir',
+	':-moz-locale-dir',
+	':state',
+	':lang',
+]);
+
 /** @type {import('stylelint').CoreRules[ruleName]} */
 const rule = (primary, secondaryOptions) => {
 	return (root, result) => {
@@ -86,7 +94,9 @@ const rule = (primary, secondaryOptions) => {
 
 				if (optionsMatches(secondaryOptions, 'ignoreTypes', tagNode.value)) return;
 
-				if (isArgumentOfIgnoredPseudoElement(tagNode)) return;
+				if (isArgumentOfIgnoredPseudoElement(tagNode) || isArgumentOfIgnoredPseudoClass(tagNode)) {
+					return;
+				}
 
 				const tagName = tagNode.value;
 				const tagNameLowerCase = tagName.toLowerCase();
@@ -124,6 +134,13 @@ function isArgumentOfIgnoredPseudoElement(tag) {
 	return parser.isPseudoElement(node) && IGNORED_PSEUDO_ELEMENTS.has(node.value);
 }
 
+/** @param {import('postcss-selector-parser').Tag} tag */
+function isArgumentOfIgnoredPseudoClass(tag) {
+	const node = tag.parent?.parent;
+
+	return parser.isPseudoClass(node) && IGNORED_PSEUDO_CLASSES.has(node.value);
+}
+
 rule.ruleName = ruleName;
 rule.messages = messages;
 rule.meta = meta;
-Original file line number
+Diff line change
@@ Expand Up / @@ -73,6 +73,9 @@ testRule({ @@
     		{
     			code: '::view-transition-group(qux) {}',
     		},
+    		{
+    			code: ':active-view-transition-type(foo) {}',
+    		},
     		{
     			code: 'input:not(*) {}',
     		},
@@ Expand Down @@