remove number zero from group number map #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StumpWM expects group numbers to grow incrementally and for their numbers to match the *group-number-map*. However because group numbers start from one the tenth group created gets the group number ten, while the *group-number-map* and associated function group-map-number report its number as zero, because zero is the tenth character in that string. Removing the zero from the string removes this inconsistency, as any group-map-number that isnt present in the string is returned via princ-to-string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1180.
StumpWM expects group numbers to grow incrementally and for their numbers to match the group-number-map. However because group numbers start from one the tenth group created gets the group number ten, while the group-number-map and associated function group-map-number report its number as zero, because zero is the tenth character in that string. Removing the zero from the string removes this inconsistency, as any group-map-number that isnt present in the string is returned via princ-to-string.