Move to Java 17 as a language level #7688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
force-pushed
the
move-to-java-17-language-level
branch
from
d12c68b to
4abc026
Compare
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run helm-acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tombentley
approved these changes
Nov 24, 2022
certificate-manager/src/test/java/io/strimzi/certs/OpenSslCertManagerIT.java
Show resolved
Hide resolved
ppatierno
approved these changes
Nov 24, 2022
|
/azp run feature-gates-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
force-pushed
the
move-to-java-17-language-level
branch
from
4abc026 to
af4b6dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The PR #7624 moved Strimzi operators to Java 17 as the runtime. This PR moves the Strimzi Operators to Java 17 as a language level as well.
The exception to this are the following modules -
api,test,crd-generatorandcrd-annotationswhich stay on the Java 11 language level. The reason for that is that theapimodule is a published artifact which we expect users to use and we want it to be still usable in Java 11. The other 3 modules are dependnecies of theapimodule so they need to stay on Java 11 as well.Java 17 also does a much more strict validation of the JavaDocs. When configured to raise warnings as errors, it requires Javadocs for all public classes, methods or fields. The PR #7664 already fixed Javadocs for most modules. But there are still hundreds of errors in the
api,operator-common,cluster-operatorandtopic-operatormodules. This PR for the time being disables the raising of warnings as errors for the time being. We should try to fix the Javadocs foroperator-common,cluster-operatorandtopic-operatorin the future. But I would suggest to keep this disabled forapipermanently. Theapiclasses are mostly getters and setters without any real functionality. Documenting all of them will not add much value but will be a lot of effort. In addition, the missing comments are also on the generated classes where we cannot add the comments easily but we want to have them in the Javadocs as well.This PR also updates the Azure pipelines to use Java 17 and updates various Maven plugins to make them compatible with Java 17.
Checklist