Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system test] Remove un-necessary vertx Description annotation from t… #10976

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Dec 20, 2024

…ests

Type of change

  • Bugfix
  • Documentation

Description

This PR removes dependency from io.vertx.core.cli.annotations.Description; and adds a normal javadoc to the tests. Solves [1].

[1] - #10971

Checklist

  • Make sure all tests pass

…ests

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added this to the 0.46.0 milestone Dec 20, 2024
@see-quick see-quick requested a review from a team December 20, 2024 11:13
@see-quick see-quick self-assigned this Dec 20, 2024
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are missing AlternativeReconcileTriggersST where this is used as well?

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added ready for merge Label for PRs which are ready for merge and removed needs review labels Dec 20, 2024
@scholzj scholzj merged commit 06ed611 into strimzi:main Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] System tests using io.vertx.core.cli.annotations.Description class
2 participants