Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Add check for passing the ConfigMap field to env variable using Connect Container template #10909

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Dec 4, 2024

Type of change

  • Enhancement

Description

This PR adds check for passing the ConfigMap field value into the Connect using the ConnectContainer, which was added in #10623. Passing the data to env variables was, until now, managed by the ExternalConfiguration, but we with the ability to specify it in the ConnectContainer directly, we should check that that works as well.

Checklist

  • Make sure all tests pass

…Connect Container template

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge added this to the 0.45.0 milestone Dec 4, 2024
@im-konge im-konge requested review from scholzj and a team December 4, 2024 09:26
@im-konge im-konge self-assigned this Dec 4, 2024
@im-konge
Copy link
Member Author

im-konge commented Dec 4, 2024

@strimzi-ci run tests --profile=all --testcase=ConfigProviderST --cluster-type=k8s --cluster-version=latest

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: ConfigProviderST
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 12
OCP_VERSION: latest
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 2
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@im-konge im-konge merged commit 0c0ef02 into strimzi:main Dec 4, 2024
14 checks passed
@im-konge im-konge deleted the container-template-secret-cm-tests branch December 4, 2024 21:08
OwenCorrigan76 pushed a commit to OwenCorrigan76/strimzi-kafka-operator that referenced this pull request Dec 6, 2024
…Connect Container template (strimzi#10909)

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants