Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crds.kafkaTopic to include status subresource #10906

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix Crds.kafkaTopic to include status subresource #10906

merged 1 commit into from
Dec 4, 2024

Conversation

MikeEdgar
Copy link
Contributor

@MikeEdgar MikeEdgar commented Dec 3, 2024 •
edited
Loading

Type of change

Bugfix
Fixes #10905

Description

Update Crds.crd for KafkaTopic to create the status subresource

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@MikeEdgar
Fix Crds.kafkaTopic to include status subresource
41eadda 
Signed-off-by: Michael Edgar <medgar@redhat.com>
@MikeEdgar
Copy link
Contributor Author

Adding a test for this seemed like overkill and there doesn't seem to be a place to add without creating something new. I'm not sure this merits an entry in the CHANGELOG either (unless it's for every change). Let me know and I'll do it if needed.

scholzj
scholzj approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@scholzj scholzj requested a review from ppatierno December 3, 2024 18:06
@scholzj scholzj added this to the 0.45.0 milestone Dec 3, 2024
@MikeEdgar
Copy link
Contributor Author

So I see some tests failing in TopicControllerIT, but I don't see a connection to the change. Is this known to be flaky at times?

[ERROR] Failures: 
[ERROR] io.strimzi.operator.topic.TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube
[ERROR]   Run 1: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>
[ERROR]   Run 2: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>
[ERROR]   Run 3: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>

@see-quick
Copy link
Member

So I see some tests failing in TopicControllerIT, but I don't see a connection to the change. Is this known to be flaky at times?

[ERROR] Failures: 
[ERROR] io.strimzi.operator.topic.TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube
[ERROR]   Run 1: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>
[ERROR]   Run 2: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>
[ERROR]   Run 3: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>

Yeah, this test case is currently flaky.

@scholzj
Copy link
Member

scholzj commented Dec 4, 2024

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit c777f86 into strimzi:main Dec 4, 2024
21 checks passed
@fvaleri
Copy link
Contributor

fvaleri commented Dec 4, 2024

So I see some tests failing in TopicControllerIT, but I don't see a connection to the change. Is this known to be flaky at times?

[ERROR] Failures: 
[ERROR] io.strimzi.operator.topic.TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube
[ERROR]   Run 1: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>
[ERROR]   Run 2: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>
[ERROR]   Run 3: TopicControllerIT.shouldUpdateTopicInKafkaWhenStringConfigChangedInKube:880->shouldUpdateTopicInKafkaWhenConfigChangedInKube:871 expected: <{compression.type=snappy, cleanup.policy=compact, flush.ms=1234, index.interval.bytes=1234, min.cleanable.dirty.ratio=0.6, unclean.leader.election.enable=true}> but was: <{compression.type=producer, cleanup.policy=compact, flush.ms=1234, min.cleanable.dirty.ratio=0.6, index.interval.bytes=1234, unclean.leader.election.enable=true}>

Yeah, this test case is currently flaky.

Are we tracking this somewhere? I may look into it.

@MikeEdgar MikeEdgar deleted the issue-10905 branch December 5, 2024 10:07
OwenCorrigan76 pushed a commit to OwenCorrigan76/strimzi-kafka-operator that referenced this pull request Dec 6, 2024
@MikeEdgar
Fix Crds.kafkaTopic to include status subresource (strimzi#10906)
3cc3244 
Signed-off-by: Michael Edgar <medgar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppatierno ppatierno ppatierno approved these changes

@scholzj scholzj scholzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.

Crds.kafkaTopic does not set status subresource
5 participants
@MikeEdgar @see-quick @scholzj @fvaleri @ppatierno