-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread dump collection to report.sh #10895
Conversation
Sample output: |
a7b3567
to
b68f595
Compare
f7c5b71
to
e1c354d
Compare
I think there are two possible challenges:
As I said, probably not blockers. But it makes me wonder if this should be an optional thing enabled by some option? |
IMO, the thread dump should be collected by default, not optional, since you never know if this information useful or not. How about we collect logs twice: 1 without thread dump, 2 with thread dump. Even if there are duplicated logs, it should be fine for better investigation. That should also resolve all the concerns above. WDYT? |
That partially mitigates the second issue - but only partially because the thread dump will be still in the buffer consuming the space. Doesn't do anything with the first issue. Have you instead considered some better solution that actually addresses the issues? For example something like this?
|
I have thought about |
No, it prints it in its own stdout (i.e. the one of the |
@scholzj thanks for the jcmd suggestion. I'm using a different command with jcmd, which I think it is easier to grasp and maintain. I'm also creating a dedicated folder for thread dumps. Sample output attached. |
This patch adds thread dump collection to the report.sh tool. Unlike heap dumps, thread dumps are lightweight (~100ms), but still can help diagnose problems and better optimize application and JVM performance. Tested with both ZK and KRaft based clusters. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
89ded08
to
8682af9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Type of change
Description
This patch adds thread dump collection to the report.sh tool. Unlike heap dumps, thread dumps are lightweight (~100ms), but still can help diagnose problems and better optimize application and JVM performance. Tested with both ZK and KRaft based clusters.
Checklist