[ST] Remove SecurityST#testCertificates #10830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
scholzj
approved these changes
Nov 13, 2024
see-quick
approved these changes
Nov 13, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Nov 14, 2024
henryZrncik
approved these changes
Nov 14, 2024
Frawless
approved these changes
Nov 14, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
SecurityST#testCertificatestest, which uses OpenSSL client inside, is sensitive to every minor upgrade of the OpenSSL client during our image build. That means during every build of the images, there can be a newer version of the client, causing the test to fail.In the recent months we had few PRs that fixed the issues, however, it seems to be failing again.
After offline discussion with others, we decided to remove this test, as it really adds a small (or no) value.
The reason is that the certificates (and their functioning) are tested in all other different test -> this one just checks the connection to Kafka/ZK using the generated certificates, and then checks that the response from the OpenSSL client contains correct certificate subjects and SANs -> which can be tested on different levels (UT/IT).
Checklist