Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Update warnings for Zoo and MM1 removal #10828

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add/Update warnings for Zoo and MM1 removal #10828

merged 2 commits into from
Nov 15, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Nov 12, 2024

Type of change

  • Task

Description

We are now pretty certain the ZooKeeper and MM1 will be gone in Strimzi 0.46.0 as decided in SP|77. This PR:

  • Adds the removal warning for Zoo-based Kafka clusters
  • Updates the warning for MM1 clusters

It also adds the warning to the CHANGELOG.md.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Update CHANGELOG.md

@scholzj
Add/Update warnings for Zoo and MM1 removal
502c81b 
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.45.0 milestone Nov 12, 2024
@scholzj scholzj marked this pull request as ready for review November 12, 2024 22:35
@scholzj
Copy link
Member Author

scholzj commented Nov 12, 2024

/azp run zookeeper-regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

PaulRMellor
PaulRMellor approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggestions are just around MirrorMaker naming consistency

CHANGELOG.md Outdated Show resolved Hide resolved
...ain/java/io/strimzi/operator/cluster/operator/assembly/KafkaMirrorMakerAssemblyOperator.java Outdated Show resolved Hide resolved
...java/io/strimzi/operator/cluster/operator/assembly/KafkaMirrorMakerAssemblyOperatorTest.java Outdated Show resolved Hide resolved
...java/io/strimzi/operator/cluster/operator/assembly/KafkaMirrorMakerAssemblyOperatorTest.java Outdated Show resolved Hide resolved
...java/io/strimzi/operator/cluster/operator/assembly/KafkaMirrorMakerAssemblyOperatorTest.java Outdated Show resolved Hide resolved
@scholzj
Review comments PM
9702d7f 
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit 9ae9aea into strimzi:main Nov 15, 2024
13 checks passed
@scholzj scholzj deleted the add-and-update-removal-warnings-for-Zoo-and-MM1 branch November 15, 2024 15:59
OwenCorrigan76 pushed a commit to OwenCorrigan76/strimzi-kafka-operator that referenced this pull request Dec 6, 2024
@scholzj
Add/Update warnings for Zoo and MM1 removal (strimzi#10828)
23edd6c 
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRMellor PaulRMellor PaulRMellor approved these changes

@katheris katheris katheris approved these changes

@ppatierno ppatierno ppatierno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
4 participants
@scholzj @ppatierno @katheris @PaulRMellor