Prepare upgrade files in packit pipelines in test phase where all envs are set properly #10819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are set properly Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
For 0.44.0 we ran packit pipelines, but there were failures in upgrade tests. In turned out the problem was in calling
setup_upgrade.shon wrong place. This PR moves the script execution to test phase where all env variables are properly set so all files used within upgrade tests are prepared properly.I tested it within my fork - https://github.com/Frawless/strimzi-kafka-operator/runs/32710100554
Checklist