Remove unused userTaskID paramater from requestRebalance method in KafkaRebalanceAssemblyOperator #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fkaRebalanceAssemblyOperator Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
tinaselenge
force-pushed
the
small-refactor
branch
from
40c1c7a to
df1b56d
Compare
tinaselenge
changed the title
scholzj
approved these changes
Oct 30, 2024
|
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Description
This argument currently is always set to null. Before #10607, this was set to non null value to get the proposal status via rebalance endpoint. Now we use
user_tasksendpoint instead, therefore no longer need to pass this argument to the requestRebalance method.Checklist
Please go through this checklist and make sure all applicable tasks have been done