-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(storage): updates the storage content for KRaft and node pools #10731
Conversation
Signed-off-by: prmellor <pmellor@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit confusing as it put all the storage types to the same level ... ut they are not on the same level:
- The Ephemeral and Persistent storage is a basic choice the user has to make
- The JBOD storage is just an envelope for specifying multiple ephemeral or persistent volumes
- But the user cannot enable JBOD only later, so we should make it clear that using JBOD storage is always preferable and within the JBOD storage they should choose to use ephemeral or persistent volume, even if it is just one vlume for the time being
- The tiered storage is an addon. So the user has to pick from the first 3 and than (independently on the first choice) can enable or not enable the tiered storage. The tiered storage is also a Kafka cluster / topic property (you configure it for the whole cluster and enable for selected topics). Where as the first 3 types are property of a node.
I don't think this is completely clear here. What is also confusing is the node NOTE: The storage type cannot be changed ...
that is placed at the end, but essentially applies to the first three types only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @scholzj . I'll do some adjustments to make this clearer.
Signed-off-by: prmellor <pmellor@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some smaller comments. But the structure looks good here. Thanks.
Signed-off-by: prmellor <pmellor@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Documentation
Updates the storage content to split KRaft with node pools and ZooKeeper based config.
Includes the following changes:
Checklist
Please go through this checklist and make sure all applicable tasks have been done