Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): updates the storage content for KRaft and node pools #10731

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Oct 18, 2024

Documentation

Updates the storage content to split KRaft with node pools and ZooKeeper based config.

Includes the following changes:

  • Updates to the introduction to storage and storage considerations
  • Creates sections for storage config in KRaft (with node pool examples) and ZooKeeper specific storage config
  • Moves node pool config related to storage to the configuring storage section
  • Removes separate files on storage types to consolidate into single file
  • Removes procedures to add and remove JBOD volumes and incorporates this content into the content related to JBOD storage
  • Removes procedure to resize persistent volumes and incorporates this content into the content related to persistent storage
  • Updates to PVC naming conventions to reflect node pools

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: prmellor <pmellor@redhat.com>
@PaulRMellor PaulRMellor added this to the 0.44.0 milestone Oct 18, 2024
@PaulRMellor PaulRMellor requested a review from a team October 18, 2024 08:12
@PaulRMellor PaulRMellor self-assigned this Oct 18, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bit confusing as it put all the storage types to the same level ... ut they are not on the same level:

  • The Ephemeral and Persistent storage is a basic choice the user has to make
  • The JBOD storage is just an envelope for specifying multiple ephemeral or persistent volumes
    • But the user cannot enable JBOD only later, so we should make it clear that using JBOD storage is always preferable and within the JBOD storage they should choose to use ephemeral or persistent volume, even if it is just one vlume for the time being
  • The tiered storage is an addon. So the user has to pick from the first 3 and than (independently on the first choice) can enable or not enable the tiered storage. The tiered storage is also a Kafka cluster / topic property (you configure it for the whole cluster and enable for selected topics). Where as the first 3 types are property of a node.

I don't think this is completely clear here. What is also confusing is the node NOTE: The storage type cannot be changed ... that is placed at the end, but essentially applies to the first three types only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scholzj . I'll do some adjustments to make this clearer.

@scholzj scholzj modified the milestones: 0.44.0, 0.45.0 Oct 21, 2024
Signed-off-by: prmellor <pmellor@redhat.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some smaller comments. But the structure looks good here. Thanks.

Signed-off-by: prmellor <pmellor@redhat.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scholzj scholzj modified the milestones: 0.45.0, 0.44.0 Oct 25, 2024
@scholzj scholzj merged commit 6690fbc into strimzi:main Oct 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants