Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Fix NetworkPoliciesST test #10598

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Sep 18, 2024

Type of change

  • Bugfix

Description

This PR fixes issue introduced in #10506, where the metrics are parsed differently - we are not providing the full metrics list in String, but each metric has its own object, where the metric is split into name, labels, value etc. I forgot to fix this one test in the previous PR, as it's not running directly in our AZPs, so I didn't see that this test is failing.

Checklist

  • Make sure all tests pass

…ands

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge added this to the 0.44.0 milestone Sep 18, 2024
@im-konge im-konge requested a review from a team September 18, 2024 09:41
@im-konge im-konge self-assigned this Sep 18, 2024
@im-konge im-konge changed the title [ST] Fix testNetworkPoliciesOnListenersWhenOperatorIsInSameNamespaceAsOperands [ST] Fix NetworkPoliciesST test Sep 18, 2024
Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Frawless
Copy link
Member

/packit test --labels regression

@im-konge im-konge added ready for merge Label for PRs which are ready for merge and removed needs review labels Sep 18, 2024
@im-konge im-konge merged commit 84a9f98 into strimzi:main Sep 18, 2024
19 checks passed
@im-konge im-konge deleted the fix-metrics-network-policies branch September 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants