Roll controller nodes on num.partitions change
#10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
scholzj
changed the title
num.partitions change
see-quick
approved these changes
Sep 17, 2024
|
The change looks good to me, but tagging @showuon who reviewed the list when it was initially added for awareness. |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Sep 18, 2024
showuon
approved these changes
Sep 18, 2024
@showuon Not sure it is worth the time. Hopefully, this will finally work properly in Kafka 3.9 and we will be able to get rid of the list. |
I thought we still need it after kafka 4.0 (without ZK) because we need to know if the changed configs need to roll controller or not. Why could we get rid of the list? |
|
I thought that being able to talk to controllers should be enough for that. But maybe I'm wrong. @tinaselenge might know better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Currently, we do not roll the controller-only nodes when
num.partitionsoption changes. But this option seems to be used by the controller nodes and not brokers. So any changes to it are ignored unless the controllers are rolled. This PR adds it to the list of controller relevant options, so that we roll the controllers when it is changed.This was raised up in https://cloud-native.slack.com/archives/CMH3Q3SNP/p1726561281223539
Checklist