Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to override kaniko executor image in systemtest #10580

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

akatona84
Copy link
Contributor

Type of change

  • Test Refactoring

Description

Moved the kaniko image constant (used in tiered storage test) into Environment and made it possible to override via env var.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Copy link
Contributor

@egyedt egyedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@see-quick see-quick requested a review from Frawless September 13, 2024 11:55
Signed-off-by: Andras Katona <akatona@cloudera.com>
@akatona84 akatona84 force-pushed the kaniko-override-for-systemtest branch from af95f7a to d5f6771 Compare September 13, 2024 12:05
@im-konge
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj added this to the 0.44.0 milestone Sep 13, 2024
Signed-off-by: Andras Katona <41361962+akatona84@users.noreply.github.com>
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@Frawless
Copy link
Member

/packit test --labels regression

@scholzj
Copy link
Member

scholzj commented Sep 17, 2024

@Frawless Is the test failure related? Or can this be merged?

@im-konge
Copy link
Member

I just checked the results -> it's not related to this change, I will fix it in different PR. So we can proceed with this, thanks.

@scholzj scholzj merged commit a121218 into strimzi:main Sep 18, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants