-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to override kaniko executor image in systemtest #10580
Possibility to override kaniko executor image in systemtest #10580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Signed-off-by: Andras Katona <akatona@cloudera.com>
af95f7a
to
d5f6771
Compare
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
systemtest/src/main/java/io/strimzi/systemtest/Environment.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andras Katona <41361962+akatona84@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks :)
/packit test --labels regression |
@Frawless Is the test failure related? Or can this be merged? |
I just checked the results -> it's not related to this change, I will fix it in different PR. So we can proceed with this, thanks. |
Type of change
Description
Moved the kaniko image constant (used in tiered storage test) into Environment and made it possible to override via env var.
Checklist
Please go through this checklist and make sure all applicable tasks have been done