-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system test] [doc] connect package #10567
[system test] [doc] connect package #10567
Conversation
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits thanks!
development-docs/systemtests/io.strimzi.systemtest.connect.ConnectBuilderST.md
Show resolved
Hide resolved
development-docs/systemtests/io.strimzi.systemtest.connect.ConnectBuilderST.md
Outdated
Show resolved
Hide resolved
development-docs/systemtests/io.strimzi.systemtest.connect.ConnectBuilderST.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test descriptions are clear 👍
…nectBuilderST.md Co-authored-by: henryZrncik <henrich.zrnco@gmail.com> Signed-off-by: Maros Orsak <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I left some comments.
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectBuilderST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/connect/ConnectST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Type of change
Description
Similarly as in [1] PR. In this one, I have added a system test doc to our connect tests.
[1] - #10225
Checklist