Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system test] [doc] connect package #10567

Merged
merged 6 commits into from
Sep 15, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Sep 11, 2024

Type of change

  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Similarly as in [1] PR. In this one, I have added a system test doc to our connect tests.

[1] - #10225

Checklist

  • Write tests
  • Make sure all tests pass

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added this to the 0.44.0 milestone Sep 11, 2024
@see-quick see-quick requested a review from a team September 11, 2024 12:22
@see-quick see-quick self-assigned this Sep 11, 2024
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Copy link
Contributor

@henryZrncik henryZrncik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits thanks!

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test descriptions are clear 👍

see-quick and others added 2 commits September 12, 2024 13:40
…nectBuilderST.md

Co-authored-by: henryZrncik <henrich.zrnco@gmail.com>
Signed-off-by: Maros Orsak <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I left some comments.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added ready for merge Label for PRs which are ready for merge and removed needs review labels Sep 15, 2024
@see-quick see-quick merged commit 6f0d5a5 into strimzi:main Sep 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants