Deprecate the External Configuration Volumes #10566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
im-konge
approved these changes
Sep 11, 2024
documentation/modules/configuring/proc-loading-config-from-file.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Sep 12, 2024
documentation/modules/configuring/proc-loading-config-from-file.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-loading-config-from-files.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
ppatierno
approved these changes
Sep 12, 2024
PaulRMellor
approved these changes
Sep 12, 2024
api/src/main/java/io/strimzi/api/kafka/model/connect/ExternalConfiguration.java
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-loading-config-from-file.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-loading-config-from-file.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-loading-config-from-files.adoc
Outdated
Show resolved
Hide resolved
documentation/modules/configuring/proc-loading-config-from-files.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
Thanks. Your suggestions (as always) look better than my texts :-D. |
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
In Strimzi 0.43, we added the additional volumes feature -> it can be used with any container to mount new volumes based on Secret, ConfigMap, EmptyDir or PVC.
But already previously, in Kafka Connect, we had the External configuration volumes that allow to mount additional Secret or ConfigMaps as a volume to the Connect containers. So this now duplicates the newly added additional volumes feature.
This PR deprecates the External Configuration volumes. Reducing a duplicate functionality would simplify the code maintenance and testing going forward. It also updates the documentation to also use the additional volumes instead of the external configuration volumes. The API will be still present and used until it is removed in
v1API.Checklist