Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the TestSeparator to indicate if the test failed or succeeded #10554

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Sep 8, 2024

Type of change

  • Enhancement / new feature

Description

The TestSeparator makes it easier to spot where one test ends / another one starts. But sometimes - especially with system tests - the success or failure is not always obvious from the log while the test is still running. This PR checks the result and instead of just indicating that the test FINISHED it suggests that it FAILED or SUCCEEDED.

Checklist

  • Make sure all tests pass

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.44.0 milestone Sep 8, 2024
@scholzj scholzj requested a review from a team September 8, 2024 13:42
@scholzj
Copy link
Member Author

scholzj commented Sep 8, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@scholzj scholzj merged commit d0930c7 into strimzi:main Sep 9, 2024
21 checks passed
@scholzj scholzj deleted the improve-the-test-separator-to-indicate-success-or-failure branch September 9, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants