[ST] Upgrade tests removal of resources from co-namespace #10512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
force-pushed
the
co-namespace-upgrade-resources-rm
branch
from
cacb89f to
5167d99
Compare
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
henryZrncik
force-pushed
the
co-namespace-upgrade-resources-rm
branch
from
5167d99 to
74daff0
Compare
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
im-konge
reviewed
Sep 2, 2024
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftStrimziDowngradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftStrimziDowngradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftStrimziUpgradeST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftStrimziUpgradeST.java
Outdated
Show resolved
Hide resolved
see-quick
approved these changes
Sep 2, 2024
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftStrimziUpgradeST.java
Outdated
Show resolved
Hide resolved
henryZrncik
force-pushed
the
co-namespace-upgrade-resources-rm
branch
from
74daff0 to
9fd3be3
Compare
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: hzrncik <hzrncik@redhat.com>
Signed-off-by: hzrncik <hzrncik@redhat.com>
Signed-off-by: hzrncik <hzrncik@redhat.com>
henryZrncik
force-pushed
the
co-namespace-upgrade-resources-rm
branch
from
9fd3be3 to
605446f
Compare
im-konge
reviewed
Sep 3, 2024
systemtest/src/test/java/io/strimzi/systemtest/upgrade/AbstractUpgradeST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: hzrncik <hzrncik@redhat.com>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
refactor
Description
co-namespacewill not be used for creation of any resources also in upgrade/donwgrade system tests (the only exception will now be in OLM tests).Detailed changes
namespaceName.copyModifyApplyis now modified so it reflects exactly steps from documentation how to deploy cluster operator which watch multiple namesapces.TestConstants.CO_NAMESPACEandTEST_SUITE_NAMESPACEare not used if they can be passed as argument.TestConstants.CO_NAMESPACEoccurences replaced with simpleCO_NAMESPACEas both were used in different places so for at least so-so consistency.