This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
fix: #188 use separate sarama clients for producer and consumer #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppatierno could you please review? I still need to verify the latency improvement is as expected. I'll post charts (before and after) once this is done. |
k-wall
force-pushed
the
issue-188
branch
2 times, most recently
from
cbe15db to
c8e8ec0
Compare
ppatierno
approved these changes
Jun 23, 2022
scholzj
approved these changes
Jun 23, 2022
|
@k-wall other than posting your results about latency before merging, could you push a line on the CHANGELOG mentioning this change please? |
|
Latency results showing the end to end latency for both Strimzi 0.3.0 and Strimzi main + the PR. I believe this demonstrates that the change is effective with the 99.5% percentile being 20-50ms. One thing the test did highlight is that the canary's default buckets are no longer appropriate. I'll suggest new values as a separate PR.
|
Sharing a client meant that the client's await for FetchResponse could skew the latency measurement. This change means that the producer and consumer services create their own clients. Signed-off-by: Keith Wall <kwall@apache.org>
melchiormoulin
pushed a commit
to melchiormoulin/strimzi-canary
that referenced
this pull request
Jun 29, 2022
strimzi#193) Sharing a client meant that the client's await for FetchResponse could skew the latency measurement. This change means that the producer and consumer services create their own clients. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Melchior Moulin <melchior.moulin@gmail.com>
melchiormoulin
pushed a commit
to melchiormoulin/strimzi-canary
that referenced
this pull request
Jul 3, 2022
strimzi#193) Sharing a client meant that the client's await for FetchResponse could skew the latency measurement. This change means that the producer and consumer services create their own clients. Signed-off-by: Keith Wall <kwall@apache.org> Signed-off-by: Melchior Moulin <melchior.moulin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing a client meant that the client's await for FetchResponse could skew the latency measurement. This change means that the producer and consumer services create their own clients. This will increase the number of connections consumed by the canary on the kafka cluster (by 33%).
Signed-off-by: Keith Wall kwall@apache.org