[Graphics] Dx11: Fix ResizeBuffer when swap chain is under flip model and changing format #1814
Conversation
… and changing format
|
And a big thanks to @Perksey for helping me out with this issue |
|
I don’t really understand why the asset view would change the render target format based on the asset? This doesn’t sound right. But your PR looks good to me. Especially that it now throws if the format is not supported under the flip model. Removing the auto switch entirely would for sure also be an option, just hard to say what implications that could have on existing apps. |
|
Thanks a bunch for getting back to me so fast and looking through this @azeno, really appreciate it ! Windows - Simple (Tests) fails, looking at the history it has been randomly failing off and on for a while now, even on the same method so unlikely to be caused by this. I'll take a look into that after merging. |
I think the asset view does that in order to properly show the preview of some assets that must be shown as they are (without gamma conversion), like normal maps or heightmaps (which must be linear), and maybe others also. |
PR Details
Why this issue occurred:
Flip model supports 3 different formats, none of them are sRGB.
The asset view swaps between gamma and linear rendering depending on the asset, so non-sRGB and sRGB format.
When the swap chain is initialized, the logic stripped out the sRGB specifier from the format provided, so it never could crash then.
But when the view changes size or format, ResizeBuffer is called, if the format requested is sRGB it won't be stripped out, so it'll silently crash the application.
What this PR does:
Ensures that the format, when creating and on resize, is not only non-sRGB but also supported by flip model.
This seems a bit weird for me though, should we not require the callers to provide a format that is compatible with the flip model if they do enable it, instead of silently fixing the format for them ? I can understand doing so if there are no difference in visuals but that seems unlikely ? Maybe you could chime in @azeno ?
Related Issue
Fixes #1770
Related to PR #1594
Types of changes
Checklist