Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] PropertyGrid, fix member sorting by declaration/token #1790

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[Editor] PropertyGrid, fix member sorting by declaration/token #1790

merged 1 commit into from
Sep 19, 2023

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Sep 18, 2023

PR Details

Looks like sorting was already in declaration order pre-github, but MemberInfo became obsolete and is never assigned.

image

public class MemberOrderTest : EntityComponent
{
    public float z, y, x;
    public float a, b, c;
}

Related Issue

None logged afaict.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Eideren Eideren changed the title [Editor] PropertyGrid, re-implement member sorting by declaration/token [Editor] PropertyGrid, fix member sorting by declaration/token Sep 18, 2023
manio143
manio143 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@manio143 manio143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you inlined CompareMetadataTokenWith here?

@Eideren
Copy link
Collaborator Author

Eideren commented Sep 19, 2023

Yes, the idea was to strip the dependency over MemberInfo, which makes it very clear that this field is not supposed to be used willy-nilly.

@Eideren Eideren merged commit c44205c into stride3d:master Sep 19, 2023
@Eideren Eideren deleted the prop_grid_sort branch September 30, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manio143 manio143 manio143 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eideren @manio143