Improve Facebook workflow #3120

holiber · 2020-11-17T20:54:10Z

allow streaming to groups
allow streaming to the user's timeline
allow selecting a scheduled event for streaming
the vue-multiselect library has been updated (I needed to update this library because the new version allows better customization)
game selectors for twitch and facebook are different inputs now
the twitch game selector shows a game image
CustomResolution input has improved UX now
streaming tests have been sliced by several files
added a privacy parameter for FB streams

gettinToasty

overall seems to mostly make sense, had a few non-blocking questions

gettinToasty · 2020-11-17T23:56:15Z

app/components/shared/inputs/BaseFormGroup.ts

-    delete inputMetadata.description;
+    if (options.type === 'bool') {
+      // FormGroup handle the render of the FormInput title
+      // so remove the title from FormInput metadata


is this only true of bool inputs? i thought most inputs behaved that way

Only bool inputs show their title and tooltip independently from FormGroup

gettinToasty · 2020-11-18T18:10:59Z

app/components/windows/ShareStream.tsx

@@ -127,7 +127,8 @@ export default class ShareStream extends TsxComponent<{ sharePageUrl: string }>
  }

  get sharePageUrl() {
-    return `facebook.com/${this.facebookService.state.activePage.name}-${this.facebookService.state.activePage.id}`;
+    return '';
+    // return `facebook.com/${this.facebookService.state.activePage.name}-${this.facebookService.state.activePage.id}`;


i thought that we got rid of this page entirely?

Yeah I'm also curious where this component is being used. Can we delete?

We can get rid of this component

gettinToasty · 2020-11-18T18:16:36Z

app/components/windows/go-live/PlatformSettings.tsx

@@ -58,7 +58,7 @@ export default class PlatformSettings extends TsxComponent<Props> {
    return (
      <ValidatedForm class="flex" ref="settingsForm">
        <div style={{ width: '100%' }}>
-          {!hasPlatforms && $t('Enable at least one destination to start streaming')}
+          {!hasPlatforms && $t('Enable at least one destinationType to start streaming')}


i feel like we should not use camelCase in any user-facing copy

Looks like another find-replace error

My IDE did a bad job with replacing =(

gettinToasty · 2020-11-18T18:17:08Z

app/components/windows/go-live/ScheduleStreamWindow.tsx

@@ -190,7 +190,7 @@ export default class ScheduleStreamWindow extends TsxComponent<{}> {
                <HFormGroup metadata={this.formMetadata.time} vModel={this.startTimeModel.time} />
              </div>
            )}
-            {shouldShowWarn && <div>{$t('Select at least one destination')}</div>}
+            {shouldShowWarn && <div>{$t('Select at least one destinationType')}</div>}


same as above comment

Another one :)

gettinToasty · 2020-11-18T18:20:28Z

app/services/platforms/mixer.ts

@@ -186,7 +186,7 @@ export class MixerService extends BasePlatformService<IMixerServiceState>
    ).then(json => json.viewersCurrent);
  }

-  async putChannelInfo({ title, game }: IMixerStartStreamOptions): Promise<boolean> {
+  async putChannelInfo({ title, game }: IMixerStartStreamOptions): Promise<void> {


I think technically speaking we could just get rid of this whole service right?

Yes, we can. I prefer to not do it as a part of this PR

gettinToasty · 2020-11-18T18:21:12Z

app/services/platforms/twitch.ts

+        .replace('{width}', imageSize.width.toString())
+        .replace('{height}', imageSize.height.toString());
+      return { id: g.id, name: g.name, image };
+    })[0];


love to see us switching over to the new twitch api whenever possible

avacreeth · 2020-11-18T18:30:26Z

app/components/LiveDock.vue.ts

@@ -65,7 +66,7 @@ export default class LiveDock extends Vue {
    this.underlyingSelectedChat = val;
  }

-  viewStreamTooltip = $t('Go to YouTube to view your live stream');
+  viewStreamTooltip = $t('Open browser to view your live stream');


Let's change this to "View your live stream in a web browser"

avacreeth · 2020-11-18T18:34:00Z

app/components/windows/ShareStream.tsx

@@ -75,7 +75,7 @@ export default class ShareStream extends TsxComponent<{ sharePageUrl: string }>
  };

  mounted() {
-    this.facebookService.sendPushNotif();
+    // this.facebookService.sendPushNotif();


avacreeth · 2020-11-18T18:34:37Z

app/components/windows/ShareStream.tsx

@@ -127,7 +127,8 @@ export default class ShareStream extends TsxComponent<{ sharePageUrl: string }>
  }

  get sharePageUrl() {
-    return `facebook.com/${this.facebookService.state.activePage.name}-${this.facebookService.state.activePage.id}`;
+    return '';
+    // return `facebook.com/${this.facebookService.state.activePage.name}-${this.facebookService.state.activePage.id}`;


Yeah I'm also curious where this component is being used. Can we delete?

avacreeth · 2020-11-18T18:35:26Z

app/components/windows/go-live/DestinationSwitchers.tsx

@@ -88,7 +88,7 @@ export class DestinationSwitchers extends TsxComponent<Props> {
            {isPrimary ? (
              <span
                vTooltip={$t(
-                  'You cannot disable the platform you used to sign in to Streamlabs OBS. Please sign in with a different platform to disable streaming to this destination.',
+                  'You cannot disable the platform you used to sign in to Streamlabs OBS. Please sign in with a different platform to disable streaming to this destinationType.',


Lol - this looks like a find-replace error. I assume you didn't mean to change this string.

avacreeth · 2020-11-18T18:35:39Z

app/components/windows/go-live/DestinationSwitchers.tsx

@@ -114,7 +114,7 @@ export class DestinationSwitchers extends TsxComponent<Props> {
  }

  /**
-   * Renders a switcher for a custom destination
+   * Renders a switcher for a custom destinationType


Also looks like a find-replace error

avacreeth · 2020-11-18T18:43:08Z

app/components/windows/go-live/PlatformSettings.tsx

@@ -58,7 +58,7 @@ export default class PlatformSettings extends TsxComponent<Props> {
    return (
      <ValidatedForm class="flex" ref="settingsForm">
        <div style={{ width: '100%' }}>
-          {!hasPlatforms && $t('Enable at least one destination to start streaming')}
+          {!hasPlatforms && $t('Enable at least one destinationType to start streaming')}


Looks like another find-replace error

avacreeth · 2020-11-18T18:43:22Z

app/components/windows/go-live/ScheduleStreamWindow.tsx

@@ -190,7 +190,7 @@ export default class ScheduleStreamWindow extends TsxComponent<{}> {
                <HFormGroup metadata={this.formMetadata.time} vModel={this.startTimeModel.time} />
              </div>
            )}
-            {shouldShowWarn && <div>{$t('Select at least one destination')}</div>}
+            {shouldShowWarn && <div>{$t('Select at least one destinationType')}</div>}


Another one :)

avacreeth · 2020-11-18T18:46:15Z

app/components/windows/go-live/platforms/FacebookEditStreamInfo.tsx

+              imageSize={{ width: 44, height: 44 }}
+            />
+            <p>
+              {$t('Make sure Streamlabs app is added to your Group.')}


"Make sure the Streamlabs app is added to your Group."

holiber added 30 commits November 17, 2020 12:22

Stream to FB event

2918e52

add events

50b188b

add fixes

b802fb9

temporary commit

7568486

save progress

f8615f0

revert icons

917e66d

revert destination rename

79ab99e

update and schedule fixes

dcefa72

add extra fields

2dd2cb0

add admin filter

0149049

fix fetchGroups

61c7c51

fetch groups to state

4f9ff43

update selector

e7a2e5a

fix resolution input

9613702

more events

abb1409

first preview

6f64713

finalize

486f7de

add translations

d14721a

fix tests

7ed2661

fb events

ac6de1e

recording tests

74cab40

fix translations

53e5ff7

fix test

28552b4

fix strict nulls

462a565

add changes

7b59f93

fix tests

5543b88

fix destination selector

416ed54

Streaming to the scheduled event on Facebook

f13fa55

uupdate tests

d0f6a6a

refactor folders structure for streaming tests

dae1f47

holiber and others added 14 commits November 17, 2020 12:40

fix YT test

f8fee26

fix multistream test

eb16ba9

fix typo in group edit link

a404323

fix datepicker cursor

6c85410

fix disabled list input styles

67b550c

fix chat loading

b7d37c6

remove facebook scrollbars

5523940

add privacy settings

a59f4ac

fix tests

5f8ecd7

delete no-fb-pages test

f287d90

fetch facebook permissions

34aabda

rebase

cbc2bb6

Merge branch 'master' into fb_events_2

9b32efb

fix streamlabels

0a103a3

gettinToasty approved these changes Nov 18, 2020

View reviewed changes

avacreeth requested changes Nov 18, 2020

View reviewed changes

holiber added 2 commits November 18, 2020 12:36

CR fixes

77ef8e8

custom dest

47f7846

avacreeth merged commit 3d537ad into master Nov 19, 2020

avacreeth deleted the fb_events_2 branch November 19, 2020 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Facebook workflow #3120

Improve Facebook workflow #3120

holiber commented Nov 17, 2020 •

edited

Loading

gettinToasty left a comment

gettinToasty Nov 17, 2020

holiber Nov 18, 2020

gettinToasty Nov 18, 2020

avacreeth Nov 18, 2020

holiber Nov 18, 2020

gettinToasty Nov 18, 2020

avacreeth Nov 18, 2020

holiber Nov 18, 2020

gettinToasty Nov 18, 2020

avacreeth Nov 18, 2020

gettinToasty Nov 18, 2020

holiber Nov 18, 2020

gettinToasty Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

avacreeth Nov 18, 2020

Improve Facebook workflow #3120

Improve Facebook workflow #3120

Conversation

holiber commented Nov 17, 2020 • edited Loading

gettinToasty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

holiber commented Nov 17, 2020 •

edited

Loading