Chatbot v3 #1394

AnkhHeart · 2019-02-19T17:20:14Z

Loyalty Implmentation
Heist Implementation
Betting Implementation
Poll Implementation
Fixed NumberInput
Added enter/return blocking option to TextArea
Gamble Minigame Implemented
Importer from Extension & SE Implemented
Queue Implemented
Quotes Implmeneted

… into staging

very much a WIP, it looks like there isn't even an api endpoint for this yet. Things to do:

… into staging

codeclimate

The PR diff size of 12484 lines exceeds the maximum allowed for the inline comments feature.

- Removed @keydown.enter.prevent since handleInput does it when blockReturn is set to true

…s-obs into chatbot-v3

codeclimate

The PR diff size of 12483 lines exceeds the maximum allowed for the inline comments feature.

AppVeyorBot · 2019-02-22T21:03:01Z

8645501

AppVeyorBot · 2019-02-22T21:33:09Z

❌ build failed 0861fbb

- hide songrequest default commands

codeclimate

The PR diff size of 12482 lines exceeds the maximum allowed for the inline comments feature.

avacreeth

Nothing major from me. I would like to see all instances of any replaced with interfaces/types before we merge this though.

avacreeth · 2019-02-22T21:15:12Z

app/components/page-components/Chatbot/windows/ChatbotBettingProfileWindow.vue.ts

+    this.$modal.show(this.NEW_BET_OPTION_MODAL_ID);
+  }
+
+  onAddedHandler(option: IBettingOption = null, index: number = -1) {


Can this be extracted? This is now the 3rd time this function has been copy pasted I think.

avacreeth · 2019-02-22T21:38:37Z

app/components/ModalLayout.vue

@@ -69,6 +71,19 @@
  }
 }

+.modal-layout-tab-content {
+    flex-grow: 1;


indentation is wrong

avacreeth · 2019-02-22T21:38:49Z

app/components/ModalLayout.vue.ts

@@ -23,6 +23,10 @@ export default class ModalLayout extends Vue {
  // cancel button.
  @Prop({ default: true }) showCancel: boolean;

+  // If controls are shown, whether or not to show the
+  // cancel button.


This comment is wrong.

I'm a little unclear what this option is meant to do. Maybe it will be obvious once the correct comment is added.

avacreeth · 2019-02-22T21:40:47Z

app/components/TopNav.vue

@@ -12,7 +12,7 @@
  <div class="tabs">
    <button
      @click="navigateDashboard"
-      class="tab-button"
+      class="tab-button tab-button--dashboard"


Does this class exist anywhere? I don't see why this was added.

avacreeth · 2019-02-22T21:41:33Z

app/components/custom-source-properties/WidgetProperties.vue.ts

+      this.navigationService.navigate('Chatbot');
+      this.chatbotApiChatbotApiService.Common.openSongRequestPreferencesWindow();
+      return;
+    }*/


Can we delete this?

avacreeth · 2019-02-22T22:55:00Z

app/services/chatbot/chatbot-poll.ts

+      this.RESET_ACTIVE_POLL();
+    });
+
+    this.socket.on('poll.update', (response: any) => {


Can we define interfaces for the following 3 responses?

avacreeth · 2019-02-22T22:56:17Z

app/services/chatbot/chatbot-poll.ts

+  }
+
+  @mutation()
+  private UPDATE_POLL_OPTIONS(options: any) {


avacreeth · 2019-02-22T22:56:27Z

app/services/chatbot/chatbot-poll.ts

+  }
+
+  @mutation()
+  private UPDATE_POLL_TIMER(data: any) {


avacreeth · 2019-02-22T22:57:13Z

app/services/chatbot/chatbot-songrequest.ts

+  }
+
+  updateSongRequestPreferencesData(data: any) {
+    // NOTE: should update type


avacreeth · 2019-02-22T22:59:27Z

app/services/platform-apps/index.ts

@@ -2,7 +2,7 @@ import { mutation, StatefulService } from 'services/stateful-service';
 import { lazyModule } from 'util/lazy-module';
 import path from 'path';
 import fs from 'fs';
-import { Subject } from 'rxjs';
+import { BehaviorSubject, Subject } from 'rxjs';


This looks wrong.

AppVeyorBot · 2019-02-22T23:01:41Z

0b6b13e

blackxored · 2019-02-22T23:11:39Z

General comment: we can format Vue templates with prettier, which doesn't seem like they're in all cases.

holiber

Mostly LGTM, thanks for hardworking on this.

holiber · 2019-02-22T21:37:06Z

app/components/custom-source-properties/WidgetProperties.vue.ts

@@ -15,7 +15,7 @@ export default class WidgetProperties extends Vue {
  @Inject() navigationService: NavigationService;
  @Inject() windowsService: WindowsService;
  @Inject() userService: UserService;
-  @Inject() chatbotCommonService: ChatbotCommonService;
+  @Inject() chatbotApiChatbotApiService: ChatbotApiService;


This injection doesn't work. There is no such service chatbotApiChatbotApiService

holiber · 2019-02-22T21:40:40Z

app/components/obs/inputs/ObsBoolInput.vue.ts

@@ -21,7 +21,7 @@ class ObsBoolInput extends ObsInput<IObsInput<boolean>> {
  }

  handleClick() {
-    if (this.value.enabled === false) return;
+    if (!this.value.enabled) return;


Chatbot must use inputs from the shared folder. All ObsInputs are only for editing libobs values.

It is only using things from the shared folder.

So why you need this change inside the obs folder here for current PR?

app/components/page-components/Chatbot/windows/ChatbotCapsProtectionWindow.vue.ts

app/components/page-components/Chatbot/windows/ChatbotCommandPreferencesWindow.vue.ts

holiber · 2019-02-22T22:18:08Z

app/components/page-components/Chatbot/ChatbotModules.vue.ts

            ...this.chatAlerts,
            enabled: !this.chatAlertCurrentlyEnabled,
          });
        },
      },
-      {
+      /*{


Why it's commented? If you need to keep it commented pls add // TODO: explanation

app/components/page-components/Chatbot/Importer/ChatbotStreamElementsModal.vue.ts

holiber · 2019-02-22T22:40:30Z

app/components/page-components/Chatbot/Poll/ChatbotVoteTracker.vue

+    -webkit-transition: none !important;
+    -moz-transition: none !important;
+    -o-transition: none !important;
+    transition: none !important;


Electron is Chromium-based app. No need for cross-browser prefixes here

app/components/page-components/Chatbot/Poll/ChatbotVoteTracker.vue.ts

app/components/page-components/Chatbot/Poll/ChatbotPollOptionModal.vue.ts

holiber · 2019-02-22T23:43:05Z

app/services/chatbot/chatbot-betting.ts

+    const startedTimer = activePoll.settings.timer.started_at !== undefined;
+
+    if (containsSettings && containsTimer && startedTimer) {
+      const timeElapsed = Date.now() - activePoll.settings.timer.started_at;


Can't use Date.now() here.
Mutation must be a pure function that relies only on arguments and state. This method will be executed in the main and child window and Date.now() will be different.
To fix that, just pass a Date.now() as an argument for this mutation

I need the Date.now() at that point in time since I am calculating the time that has elapsed since the timer has started, it's used for a countdown / count up timer.

Good catch. I missed this.

- Removed comment from widgetproperties - Fixed modal layout formatting - modal layout comment fixed - Fixed object on add bet option modal - Betting Window now extends Poll - Added missing types in betting & poll service - Removed tab-button--dashboard - Removed BehaviorSubject

codeclimate

The PR diff size of 12474 lines exceeds the maximum allowed for the inline comments feature.

AppVeyorBot · 2019-02-23T00:28:18Z

976fbe3

- Updated update timer, passes Date.now() - Removed unecessary injection - Removed uuid mentions - Added TODO comment

codeclimate

The PR diff size of 12478 lines exceeds the maximum allowed for the inline comments feature.

AppVeyorBot · 2019-02-23T01:50:29Z

❌ build failed c634d4c Build execution time has reached the maximum allowed time for your plan (60 minutes).

- Removed browser specific transitions

codeclimate

The PR diff size of 12472 lines exceeds the maximum allowed for the inline comments feature.

AppVeyorBot · 2019-02-25T21:16:22Z

❌ build failed a47e3db Build execution time has reached the maximum allowed time for your plan (60 minutes).

holiber

add .env to .gitignore and good to merge

- ignore .env

- Remove env variable

codeclimate

The PR diff size of 12474 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 12473 lines exceeds the maximum allowed for the inline comments feature.

AppVeyorBot · 2019-02-27T21:02:08Z

b6375d5

Nitsorn and others added 30 commits July 31, 2018 15:09

pulled from staging

5e5b4bd

dropdownmenu added

8ab2071

merged staging

219d66c

pulled from staging

42fe240

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

e3485c1

… into staging

merging staging

cdd5ec5

some conflict

0192fa2

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

f362635

… into staging

pulling from remote

bb88d7f

added new files from remote

9b66ca2

added alphaOnly

17150ea

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

2831a8a

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

1481978

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

bc4f1c4

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

f0048dc

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

103f028

… into staging

Build out media share skeleton

56e99a2

very much a WIP, it looks like there isn't even an api endpoint for this yet. Things to do:

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

7c4b5d3

… into staging

Rebase on staging

cdb35f9

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

5d7c4a9

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

d8ed30a

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

2d0011b

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

166d9cc

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

459bb63

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

34f4587

… into staging

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

94e578b

… into staging

added quotes

6a81386

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

262cc8d

… into staging

fixed conflict

65ec5b9

Merge branch 'staging' of https://github.com/stream-labs/streamlabs-obs…

f6f035c

… into staging

Merge branch 'staging' into chatbot-v3

0f2cf67

codeclimate bot reviewed Feb 22, 2019

View reviewed changes

AnkhHeart added 2 commits February 22, 2019 21:59

Removed @keydown.enter.prevent on textarea

885e3fa

- Removed @keydown.enter.prevent since handleInput does it when blockReturn is set to true

Merge branch 'chatbot-v3' of https://github.com/stream-labs/streamlab…

7b55485

…s-obs into chatbot-v3

codeclimate bot reviewed Feb 22, 2019

View reviewed changes

hiden songrequest commands

208f0df

- hide songrequest default commands

codeclimate bot reviewed Feb 22, 2019

View reviewed changes

avacreeth reviewed Feb 22, 2019

View reviewed changes

holiber reviewed Feb 22, 2019

View reviewed changes

codeclimate bot reviewed Feb 23, 2019

View reviewed changes

Fixes (Holiber Feedback)

f3a9325

- Updated update timer, passes Date.now() - Removed unecessary injection - Removed uuid mentions - Added TODO comment

codeclimate bot reviewed Feb 23, 2019

View reviewed changes

Removed browser specific transitions

4c3e830

- Removed browser specific transitions

codeclimate bot reviewed Feb 25, 2019

View reviewed changes

holiber approved these changes Feb 26, 2019

View reviewed changes

AnkhHeart added 2 commits February 26, 2019 22:44

ignore .env

add2657

- ignore .env

Remove env variable

70b39b9

- Remove env variable

codeclimate bot reviewed Feb 26, 2019

View reviewed changes

holiber merged commit 44e86bb into staging Feb 27, 2019

holiber deleted the chatbot-v3 branch February 27, 2019 21:17

Chatbot v3 #1394

Chatbot v3 #1394

Conversation

AnkhHeart commented Feb 19, 2019

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

AppVeyorBot commented Feb 22, 2019

AppVeyorBot commented Feb 22, 2019

codeclimate bot left a comment

Choose a reason for hiding this comment

avacreeth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AppVeyorBot commented Feb 22, 2019

blackxored commented Feb 22, 2019

holiber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

holiber Feb 22, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

AppVeyorBot commented Feb 23, 2019

codeclimate bot left a comment

Choose a reason for hiding this comment

AppVeyorBot commented Feb 23, 2019

codeclimate bot left a comment

Choose a reason for hiding this comment

AppVeyorBot commented Feb 25, 2019

holiber left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

AppVeyorBot commented Feb 27, 2019

holiber Feb 22, 2019 •

edited

Loading