fix: Pages can be scrolled when hovering sticky navs #22441
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
Thanks for your contribution @Datata1 :) Would it be possible to extend this behavior to the secondary nav as well? If there's too much content in it, the secondary nav is scrollable (you can find an example in the settings of Strapi) but if there's not enough (see recording) we can still scroll the whole page even if we're hovering it. CleanShot.2024-12-16.at.12.59.51.mp4 |
|
I can add this, but I need time until Thursday because my calendar is
quite full. 😬
…On Mon, Dec 16, 2024, 1:03 PM Lucas Boilly ***@***.***> wrote:
Thanks for your contribution @Datata1 <https://github.com/Datata1> :)
Would it be possible to extend this behavior to the secondary nav as well?
If there's too much content in it, the secondary nav is scrollable (you can
find an example in the settings of Strapi) but if there's not enough (see
recording) we can still scroll the whole page even if we're hovering it.
https://github.com/user-attachments/assets/65f6b56f-3d5e-48eb-8382-67a3f60d848e
—
Reply to this email directly, view it on GitHub
<#22441 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBWGJZCIAI256F3AJCSYPDT2F26RBAVCNFSM6AAAAABTUWEKZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBVGQ2DMMRTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Datata1 that's absolutely not a problem! You can take as much time as you want of course 🙂 |
hanpaine
added
source: core:admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR introduces a change to the
LeftMenucomponent to prevent the page from scrolling when the cursor hovers over theMainNavcomponent. The implementation usesuseEffectto add and remove event listeners for thewheelevent, effectively toggling the scroll behavior based on the cursor's position.Why is it needed?
This change addresses an issue where users could inadvertently scroll the entire page when interacting with the sticky navigation bar (
MainNav).How to test it?
Go to any page and hover over the left navbar and try to scroll.
Related issue(s)/PR(s)
Fixes #22408