Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify missing id site params #251

Merged
merged 5 commits into from
Apr 11, 2016
Merged

Specify missing id site params #251

merged 5 commits into from
Apr 11, 2016

Conversation

lwcolton
Copy link

Specify onk, sof, and sp_token fields when building id site url

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e58a38b on HurricaneLabs:specify-missing-id-site-params into * on stormpath:develop*.

@lwcolton
Copy link
Author

@rdegges When you're looking at this can you also tell me if this blog you wrote is out of date? In the ID Site portion you have this line of example code:

result = app.handle_id_site_callback(request)

Which I think should instead be something like

result = app.handle_stormpath_callback(request.url)

https://stormpath.com/blog/hosted-login-and-api-authentication-for-python/

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 853a80a on HurricaneLabs:specify-missing-id-site-params into * on stormpath:develop*.

@rdegges
Copy link
Contributor

rdegges commented Apr 11, 2016

Thank you! This is perfect. And yes: that blog post is out of date, I'll update that next =)

@rdegges rdegges merged commit df9ad5e into stormpath:develop Apr 11, 2016
rdegges added a commit that referenced this pull request Apr 11, 2016
@rdegges
Copy link
Contributor

rdegges commented Apr 11, 2016

Just cut a release with this included =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants