Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node 12 #729

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Use node 12 #729

merged 1 commit into from
Oct 22, 2019

Conversation

XVincentX
Copy link
Contributor

Our docker images are based on node 12 and Windows tests run on node 12. We're on node 12, let's claim that.

karol-maciaszek
karol-maciaszek approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@XVincentX XVincentX merged commit 6227cc5 into master Oct 22, 2019
@XVincentX XVincentX deleted the node12 branch October 22, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-maciaszek karol-maciaszek karol-maciaszek approved these changes

@lag-of-death lag-of-death Awaiting requested review from lag-of-death

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVincentX @karol-maciaszek