fix: logger component is always required #713
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lag-of-death
approved these changes
Oct 15, 2019
karol-maciaszek
suggested changes
Oct 15, 2019
| @@ -14,7 +14,7 @@ export const createServer = (operations: IHttpOperation[], opts: IPrismHttpServe | |||
| const { components, config } = opts; | |||
|
|
|||
| const server = fastify({ | |||
| logger: (components && components.logger) || createLogger('HTTP SERVER'), | |||
| logger: components.logger, | |||
There was a problem hiding this comment.
I think we should lean towards having more default parameters. Ideally, a user should be able to spin up the server with just: createServer([])
There was a problem hiding this comment.
The final user will always be able. They use the public client which has everything defaulted so they'll be able to use it with no parameters at all.
On the other hand, this is the internal client that I am using to create the hosted Prism version and this one requires this stuff.
Does that clarify?
XVincentX
force-pushed
the
fix/components-requiredt
branch
from
5ed1af6 to
6502789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that although we're claiming that the
componentsobject is not required, it is indeed required because the logger instance is always required.This PR fixes this so that when using the http raw client package to have the hosted Prism version I do not incur in the problem of having something required not passed because of TypeScript not complaining.