Fix/dynamic response fields #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
requested review from
lag-of-death,
philsturgeon and
karol-maciaszek
XVincentX
added a commit
that referenced
this pull request
Sep 17, 2019
* chore: upgrade jsf * test: add e2e * chore: switch back to npm version * docs: changelog * test: dry
XVincentX
pushed a commit
that referenced
this pull request
Sep 23, 2019
* fix: allow empty responses * chore: add changelog line * feat: answer with an empty response * Fix/dynamic response fields (#623) * chore: upgrade jsf * test: add e2e * chore: switch back to npm version * docs: changelog * test: dry * refactor: use options and closures * refactor: use fromOption * refactor: do not pass logger to whenNoContent * refactor: rename whenNoContent * test: fix * test: make the tests clearer * feat: responding with empty payloads - wip * refactor: address feedback * refactor: rm direct import of fromNullable * refactor: some cleanup * refactor: use info instead of warn * refactor: adjust to mater changes * chore: add todo * Update packages/http/src/mocker/negotiator/InternalHelpers.ts Co-Authored-By: Vincenzo Chianese <vincenz.chianese@icloud.com> * refactor: rename warnMsg to outputNoContentFoundMessage * refactor: address some feedback * refactor: do not check if 400/422 response * refactor: simplify logic * refactor: renaming * refactor: change the way of casting * test: adjust tests descriptions * refactor: put mediaTypes in pipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #570
See #570 and #605
Two notes: