Fix/oas23 body param validation nographite #501
Merged
+3,320
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
reviewed
Jul 29, 2019
packages/http-server/src/__tests__/body-params-validation.spec.ts
Outdated
Show resolved
Hide resolved
packages/http-server/src/__tests__/body-params-validation.spec.ts
Outdated
Show resolved
Hide resolved
packages/http-server/src/__tests__/body-params-validation.spec.ts
Outdated
Show resolved
Hide resolved
XVincentX
suggested changes
Jul 30, 2019
There was a problem hiding this comment.
Ok I had another look.
It was a little bit hard to review; I got confused I because of the unsupported tests and the amount of tests — which is good anyway :)
I think we have a bug in httpSpec package, which is treating the required parameter as true by default, but the spec is saying the opposite.
packages/http-server/src/__tests__/body-params-validation.spec.ts
Outdated
Show resolved
Hide resolved
packages/http-server/src/__tests__/body-params-validation.spec.ts
Outdated
Show resolved
Hide resolved
packages/http-server/src/__tests__/fixtures/encodings.oas3.yaml
Outdated
Show resolved
Hide resolved
test-harness/specs/validate-body-params/form-byte-format-fail.oas2.txt
Outdated
Show resolved
Hide resolved
...-harness/specs/validate-body-params/form-data-encoding-contenttype-fail.oas3.txt.unsupported
Outdated
Show resolved
Hide resolved
test-harness/specs/validate-body-params/form-data-invalid-request.oas3.txt
Outdated
Show resolved
Hide resolved
test-harness/specs/validate-body-params/form-dont-allow-empty-values.oas2.txt.unsupported
Outdated
Show resolved
Hide resolved
XVincentX
reviewed
Jul 30, 2019
test-harness/specs/validate-body-params/form-dont-allow-empty-values.oas2.txt.unsupported
Outdated
Show resolved
Hide resolved
test-harness/specs/validate-body-params/form-data-encoding-contenttype-ok.oas3.txt.unsupported
Outdated
Show resolved
Hide resolved
...-harness/specs/validate-body-params/form-data-encoding-contenttype-fail.oas3.txt.unsupported
Outdated
Show resolved
Hide resolved
test-harness/specs/validate-body-params/form-data-allow-reserved-fail.oas3.txt.unsupported
Outdated
Show resolved
Hide resolved
test-harness/specs/validate-body-params/form-allow-empty-values.oas2.txt.unsupported
Outdated
Show resolved
Hide resolved
|
@chris-miaskowski also — do not forget to update the CHANGELOG.md |
philsturgeon
reviewed
Aug 1, 2019
packages/http-server/src/__tests__/body-params-validation.spec.ts
Outdated
Show resolved
Hide resolved
philsturgeon
reviewed
Aug 1, 2019
packages/http-server/src/__tests__/fixtures/operations-with-body-param.oas2.yaml
Outdated
Show resolved
Hide resolved
philsturgeon
approved these changes
Aug 1, 2019
XVincentX
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #408
Closes #483