test: additional examples for default responses #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
test/add-e2e-default-responses-tests_failing
branch
from
30c7739 to
0aaf369
Compare
XVincentX
force-pushed
the
test/add-e2e-default-responses-tests_failing
branch
from
4c58071 to
890dbfa
Compare
XVincentX
force-pushed
the
test/add-e2e-default-responses-tests_failing
branch
from
a33b95f to
e97d23b
Compare
|
Comment on these failing tests: according to the code this is failing “on purpose”. The ability to look for the closest response is implemented only for successful responses; so you can do 2XX, and you’ll get the first one. Do you want to make the change and expand it to other responses as well, such as 4XX (which is the part of this test?) |
philsturgeon
previously approved these changes
Jul 17, 2019
packages/http/package.json
Outdated
| @@ -24,7 +24,7 @@ | |||
| "caseless": "^0.12.0", | |||
| "faker": "^4.1.0", | |||
| "fp-ts": "^1.19.3", | |||
| "json-schema-faker": "json-schema-faker/json-schema-faker", | |||
| "json-schema-faker": "XVincentX/json-schema-faker", | |||
There was a problem hiding this comment.
Hmm, this is a leftover. Will fix.
|
@lag-of-death I had a go at fixing the conflicts but there is still a yarn.lock change floating around which I don't think should be there. These tests look great, if you can fix that I'll thumbs up and we're done here! 🎉 |
|
@phil, |
philsturgeon
previously approved these changes
Jul 19, 2019
|
BLOCKED: #413 (comment) |
XVincentX
force-pushed
the
test/add-e2e-default-responses-tests_failing
branch
from
cf31d14 to
7b24d3c
Compare
XVincentX
force-pushed
the
test/add-e2e-default-responses-tests_failing
branch
from
36870ae to
6c07710
Compare
XVincentX
approved these changes
Jul 23, 2019
XVincentX
changed the title
philsturgeon
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds failing examples for #413. The passing ones are in #465.
Closes #413