refactor: Payload Generator improvements SO-232 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
feat/simple-generator
branch
from
4566f5e to
7f41cf4
Compare
XVincentX
changed the title
packages/http/src/mocker/generator/__tests__/JSONSchema.spec.ts
Outdated
Show resolved
Hide resolved
philsturgeon
previously approved these changes
May 25, 2019
| 'x-expires-after': expect.any(String), | ||
| 'x-strange-header': file === 'petstore.oas3.json' ? 'string' : '{}', | ||
| 'x-strange-header': file === 'petstore.oas3.json' ? 'string' : {}, |
There was a problem hiding this comment.
This but confuses me. Why was it ‘{}’ before and why is it {} now? They both seem like funny things to happen, don’t we just want an empty string for a header?
There was a problem hiding this comment.
Good question, I actually wanted to brief/ask you about this anyway.
In OpenAPI 3 documents the schema has a separate property in the Header object (example or examples) — in OAS2 the schema is "melted" with the header definition itself.
For this reason, JSON Schema Faker is kind of confused and generates an empty object for a schema that's not really complete/defined.
I can add a small workaround to standardise the behaviour. Up to you!
philsturgeon
previously approved these changes
May 27, 2019
philsturgeon
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revisits a little bit the way we generate the examples from JSON Schemas.
Note: While refactoring the code I also spotted a test passing incorrectly because of a spy that wasn't reset. https://github.com/stoplightio/prism/pull/322/files#diff-e53e98c10a813d2d271cc0fa5c55ddcaR201