Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--dynamic flag for CLI SO-217 #301

Merged
merged 22 commits into from
May 21, 2019
Merged

--dynamic flag for CLI SO-217 #301

merged 22 commits into from
May 21, 2019

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented May 14, 2019 •
edited
Loading

  1. Adds the --dynamic CLI flag
  2. Prints something on the CLI if the dynamic is true
  3. Changes the configuration object to be either "false" or a full configuration object (no more hidden defaults)
  4. Adds tests

image

@XVincentX XVincentX force-pushed the feat/dynamic_cli branch 2 times, most recently from b4233da to 66fb4d6 Compare May 16, 2019 15:55
@XVincentX XVincentX marked this pull request as ready for review May 16, 2019 16:01
@XVincentX XVincentX changed the title --dynamic flag for CLI --dynamic flag for CLI SO-217 May 16, 2019
@XVincentX XVincentX force-pushed the feat/dynamic_cli branch 4 times, most recently from 51c26ce to 6a12819 Compare May 17, 2019 18:52
philsturgeon
philsturgeon previously approved these changes May 20, 2019
View reviewed changes
@XVincentX
Copy link
Contributor Author

I think @chris-miaskowski should have a look here as well before merging this in.

chris-miaskowski
chris-miaskowski previously approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@chris-miaskowski chris-miaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, other than that great work @XVincentX !

@XVincentX XVincentX dismissed stale reviews from chris-miaskowski and philsturgeon via 007e6a6 May 21, 2019 14:54
@XVincentX XVincentX merged commit f1f27cf into master May 21, 2019
@XVincentX XVincentX deleted the feat/dynamic_cli branch May 21, 2019 15:00
@XVincentX XVincentX mentioned this pull request May 23, 2019
Merged
@XVincentX XVincentX added this to the Prism v3 Release milestone May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

@chris-miaskowski chris-miaskowski Awaiting requested review from chris-miaskowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Prism v3 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@XVincentX @philsturgeon @chris-miaskowski