Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update errors to match #1939 #1996

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Update errors to match #1939 #1996

merged 2 commits into from
Feb 23, 2022

Conversation

ryotrellim
Copy link
Contributor

@ryotrellim ryotrellim commented Feb 22, 2022 •
edited
Loading

Addresses docs for #1939

Summary

Doc update

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

Screenshots

If applicable, add screenshots or gifs to help demonstrate the changes. If not applicable, remove this screenshots
section before creating the PR.

Additional context

Add any other context about the pull request here. Remove this section if there is no additional context.

@ryotrellim ryotrellim requested a review from a team as a code owner February 22, 2022 15:01
@ryotrellim ryotrellim requested review from EdVinyard and removed request for a team February 22, 2022 15:01
@ryotrellim ryotrellim requested review from pamgoodrich and removed request for EdVinyard February 22, 2022 16:51
@ryotrellim
Update docs/guides/06-errors.md
e29e1e5 
Co-authored-by: Daniel A. White <daniel.white@stoplight.io>
pamgoodrich
pamgoodrich approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@pamgoodrich pamgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on @daniel-white 's requested changes.

@daniel-white daniel-white merged commit 406d659 into master Feb 23, 2022
@daniel-white daniel-white deleted the ryotrellim-docs-tweak-for-1939 branch February 23, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-white daniel-white daniel-white left review comments

@pamgoodrich pamgoodrich pamgoodrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryotrellim @daniel-white @pamgoodrich