Hyphenless followup #1192
Merged
Hyphenless followup #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prism into fix/hyphenated_query_params
…prism into fix/hyphenated_query_params # Conflicts: # test-harness/specs/content-negotiation/E2E-Accept-Content-Negotiation-AC-14.oas2.txt
…prism into fix/hyphenated_query_params
XVincentX
force-pushed
the
feat/hypheless-map
branch
from
ac4e051 to
b32a51e
Compare
XVincentX
force-pushed
the
feat/hypheless-map
branch
from
bbb3e25 to
13f5244
Compare
XVincentX
force-pushed
the
feat/hypheless-map
branch
from
4b048e2 to
a150a8d
Compare
karol-maciaszek
suggested changes
May 25, 2020
There was a problem hiding this comment.
Aren't we loosing data with current approach?
Consider this spec:
openapi: 3.0.2
paths:
/pet:
get:
parameters:
- in: query
name: pet-id
required: true
schema:
type: number
- in: query
name: petid
required: true
schema:
type: number
responses:
200:
description: ok
content:
application/json:
example: "ok"
This turns into:
[5:32:33 PM] › [CLI] ℹ info GET http://127.0.0.1:4010/pet?petid=834.7748617345209
We have lost pet-id param because after removing hyphens it looked the same as petid.
Constructive part:
I guess we should have two paths. One for hyphen-full params and second for hyphen-less ones. Last step will merge both results into single URL.
XVincentX
force-pushed
the
feat/hypheless-map
branch
from
85202ab to
c625141
Compare
XVincentX
force-pushed
the
feat/hypheless-map
branch
from
c625141 to
1279e7c
Compare
karol-maciaszek
approved these changes
May 26, 2020
Co-authored-by: Karol Maciaszek <karol@maciaszek.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the library and make it great again with dashes
P.S: Damn OpenAPI 3.
Closes #1191