fix: docker image restore #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelltoth
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will modify the docker ignore file to remove some of the stuff we do not need to build the docker image for Prism, moving the context from 16Mb to 1Mb.
This is a byproduct of a more important bug that I fixed here — yarn, when used in workspace mode, will always try to hoist everything in the main
node_modulesdirectory — which is great.The problem is that Dockerfile's copy for the children
node_modules, in such case, might fail (because the hoisting has changed the game).This PR makes sure that in the dev image a
node_modulesdirectory is always present — so that the copy will never fail.On a different topic, I think the requirements for our docker images have changed a bit and most likely we can find a better way to organize this. Not now though.