@philsturgeon

Given the requirement changes, if we can figure out WHEN exactly send a 406, this could close #288 as well.

Right now, in case the content is not found, we're returning an empty body with the requested status code. Maybe we should return a 406?

So the "returning an empty body" thing is when we have confirmed that a code should be sent back and we've just failed to find an example.

We want to add a layer in, before the example/empty stuff even comes into play, which is "are they accepting for a valid content type. If they ask for a content type the spec doesnt support according to accepts package, errors.

If they ask for a content type that is supported but doesnt have any example or schema, then empty body.

Does that make sense?

@pytlesk4 Good point on the multiple http headers — I'll write a test right now and fix it if necessary.
@philsturgeon Yes, that explains. On it!

@pytlesk4 3090fb3 and 2969c4d are checking out multiple accept headers.

@philsturgeon d120bad implements the requested behaviour. I'd suggest you to pull out the branch and check it out really quickly.

Really close!

$ http GET  http://127.0.0.1:4010/no_auth/pets\?name\=234 'Accept: image/jpeg;q=0.8, application/xml;q=0.3, text/plain;q=0.2'
HTTP/1.1 406 Not Acceptable
Connection: keep-alive
Date: Mon, 03 Jun 2019 19:05:00 GMT
content-length: 89
content-type: application/json; charset=utf-8

{
    "error": "Not Acceptable",
    "message": "Allowed: /json$/,application/json",
    "statusCode": 406
}

It should be returning a problems JSON and that message is looking a bit funky.

@philsturgeon Try it again, it should be ok now.

Vincenzos-MacBook-Stoplight:prism vncz$ curl -s -D "/dev/stderr" http://127.0.0.1:4010/no_auth/pets\?name\=234 -H 'Accept: image/jpeg;q=0.8, application/xml;q=0.3, text/plain;q=0.2' | json_pp
HTTP/1.1 406 Not Acceptable
content-type: application/problem+json
content-length: 271
Date: Mon, 03 Jun 2019 19:16:34 GMT
Connection: keep-alive

{
   "type" : "https://stoplight.io/prism/errors#NOT_ACCEPTABLE",
   "detail" : "Could not find any content that satisfies image/jpeg;q=0.8, application/xml;q=0.3, text/plain;q=0.2",
   "status" : 406,
   "title" : "The server cannot produce a response matching your content negotiation header"
}
Vincenzos-MacBook-Stoplight:prism vncz$ 

@philsturgeon Harness for 406 response added.

amazing!