-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: running prism
cli threw exception [SL-2021]
#190
Conversation
- Class constructor Command cannot be invoked without 'new' SL-2021
Apparently it does not seem to be solving the problem. I've cloned this branch and ran Also, given the bug I think it would be nice to at least run a test that the CLI runs — even simply printing the Prims version. |
Hmm interesting, are you sure you didn't have outdated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! I cleaned the whole thing and it seems like it's working correctly now.
I'd still appreciate a minimal test on the CLI (simply printing the version or something) but it can be a next step.
I tried implementing a simple unit test once and it was a pain... Jest had some problems with closing the child process as far as I recall. But yeah we should have tests for this :( |
Alternatively it could be just a command on the CI ran after the tests. That'd at least check that the CLI loads correctly. |
Oh, that's actually a good idea :) and we could check the shell's return code |
You got it!
|
SL-2021