Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @rpath support to SBJson.framework build settings #180

Merged
merged 1 commit into from
Sep 15, 2013

Conversation

nark
Copy link
Contributor

@nark nark commented Sep 8, 2013

@rpath facilitates framework embedding in OSX applications:

  1. Add 'SBJson.xcodeproj' as a subproject of your project
  2. Go to your application target Build Settings and set 'Runpath Search Path' to @loader_path/../Frameworks
  3. Add SBJson framework as a target dependency in application target Build Phases
  4. Link SBJson framework in application target Build Phases
  5. Copy SBJson framework to 'Frameworks' directory in application target Build Phases

NOTE: Should work the same with Xcode workspaces.

@stig
Copy link
Collaborator

stig commented Sep 8, 2013

Embedding already works, if you use @executable_path. I have reached the conclusion that multi-level embedding is a bad idea. (See stackoverflow for conflicts with people embedding Facebook sdk, and attempt to use this framework for example.) it's much better to specify it as a dependency.

Stig

Sent from my iPhone

On 8 Sep 2013, at 13:41, Rafael Warnault notifications@github.com wrote:

@rpath facilitates framework embedding in OSX applications:

Add 'SBJson.xcodeproj' as a subproject of your project
Go to your application target Build Settings and set 'Runpath Search Path' to @loader_path/../Frameworks
Add SBJson framework as a target dependency in application target Build Phases
Link SBJson framework in application target Build Phases
Copy SBJson framework to 'Frameworks' directory in application target Build Phases
NOTE: Should work the same with Xcode workspaces.

You can merge this Pull Request by running

git pull https://github.com/nark/json-framework master
Or view, comment on, or merge it at:

#180

Commit Summary

Add @rpath support to SBJson.framework build settings
File Changes

M SBJson.xcodeproj/project.pbxproj (2)
Patch Links:

https://github.com/stig/json-framework/pull/180.patch
https://github.com/stig/json-framework/pull/180.diff

@stig
Copy link
Collaborator

stig commented Sep 15, 2013

Ok, read up on @rpath and realise it's actually the recommended approach now, so I'll merge this. Thanks!

stig added a commit that referenced this pull request Sep 15, 2013
Add @rpath support to SBJson.framework build settings
@stig stig merged commit 325d3dd into SBJson:master Sep 15, 2013
@nark
Copy link
Contributor Author

nark commented Sep 18, 2013

Sorry I was away. Glad if it helps, you're welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants