Allow images within links in notebooks #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 06eba9e and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
timpitman
approved these changes
May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests #1398 (using pure markdown for colab links) and #1394 (no nested formatting in notebooks) merged at about the same time, but they conflicted. The syntax used in #1398 failed the check of #1394, and indeed revealed a missing piece: it's ok to have a link that contains an image in notebook markdown, because this passes through the reStructuredText conversion ok.
(This was yet more "merge skew".)
This also has replace an instance of bold-italic with plain bold in the GCN-LSTM notebook, because the CI requires that this doesn't appear (as it doesn't render correctly on Read the Docs; #1394 discusses this in more detail).