Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows fixes #4449

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Windows fixes #4449

merged 3 commits into from
Sep 6, 2024

Conversation

MonsieurNicolas
Copy link
Contributor

(refreshed previous PR that was conflicting with other changes in master)

@SirTyson -- I got a warning that 1UL << 36 is UB because the type is 32 bits

SirTyson
SirTyson approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@SirTyson SirTyson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I double checked the paper and this should always be 64 bits so ULL is better.

@MonsieurNicolas MonsieurNicolas added this pull request to the merge queue Sep 6, 2024
Merged via the queue into stellar:master with commit d95bf47 Sep 6, 2024
14 checks passed
@MonsieurNicolas MonsieurNicolas deleted the windowsFixes2024-08-27 branch September 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTyson SirTyson SirTyson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonsieurNicolas @SirTyson