Report drifting close time on local node #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
force-pushed
the
clock_drift_reporting
branch
2 times, most recently
from
ea69e1a to
94b1721
Compare
SirTyson
previously approved these changes
Jan 3, 2024
marta-lokhova
force-pushed
the
clock_drift_reporting
branch
from
94b1721 to
c454827
Compare
|
@SirTyson PTAL. I re-worked the approach a little bit: now validators compare their own close time used for nomination with close time externalized by the network. If the drift is over a certain threshold, we fire a warning. This approach is based on the assumption that most validators on the network have healthy clocks. It also catches both drifting behind and drifting ahead, so no more special-casing is needed. |
SirTyson
previously approved these changes
Jul 31, 2024
marta-lokhova
force-pushed
the
clock_drift_reporting
branch
from
c454827 to
3b2b2d9
Compare
…se time with close time externalized
marta-lokhova
force-pushed
the
clock_drift_reporting
branch
from
3b2b2d9 to
c712fe8
Compare
SirTyson
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1815