feat: add values method to array/fixed-endian-factory
#3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `values()` method was added to the typed array prototype to allow iteration over the array's values. This method returns an iterator, which can be used in a `for...of` loop or with `next()` calls to access each value in the array sequentially. This change simplifies the process of iterating over typed arrays, ensuring that code interacting with them is more readable and easier to maintain. Fixes: stdlib-js#123
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Please change the PR title to |
yuvi-mittal
changed the title
MeastroZI
reviewed
Nov 28, 2024
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| iter = arr.values(); | ||
|
|
| * @throws {TypeError} `this` must be a typed array instance | ||
| * @returns {Object} iterator for array elements | ||
| */ | ||
| setReadOnly(TypedArray.prototype, 'values', function values() { |
There was a problem hiding this comment.
Suggested change
| setReadOnly(TypedArray.prototype, 'values', function values() { | |
| setReadOnly( TypedArray.prototype, 'values', function values() { |
| var buf = this._buffer; | ||
| var len = this._length; | ||
|
|
||
| if (!isTypedArray(this)) { |
There was a problem hiding this comment.
Suggested change
| if (!isTypedArray(this)) { | |
| if ( !isTypedArray( this ) ) { |
Comment on lines
872
to
897
| throw new TypeError(format('invalid invocation. `this` is not %s %s.', CHAR2ARTICLE[dtype[0]], CTOR_NAME)); | ||
| } | ||
|
|
||
| iterator = { | ||
| 'next': function next() { | ||
| if (index < len) { | ||
| value = buf[GETTER](index * BYTES_PER_ELEMENT, isLE); | ||
| index += 1; | ||
| return { | ||
| 'value': value, | ||
| 'done': false | ||
| }; | ||
| } | ||
| return { | ||
| 'done': true | ||
| }; | ||
| } | ||
| }; | ||
|
|
||
| iterator[Symbol.iterator] = function iterator() { | ||
| return this; | ||
| }; | ||
|
|
||
| return iterator; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Please add the spaces under the every parans.. same way i have suggested
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the `values` method returns an iterator function', function test( t ) { |
There was a problem hiding this comment.
Test case like this is missing
| var iterator; | ||
| var result; | ||
| var ctor = factory( 'float64' ); | ||
| var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0, 5.0] ); |
There was a problem hiding this comment.
Suggested change
| var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0, 5.0] ); | |
| var arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0 ] ); |
| var iterator; | ||
| var result; | ||
| var ctor = factory( 'float64' ); | ||
| var arr = new ctor( 'little-endian', [10.5, 20.5, 30.5] ); |
There was a problem hiding this comment.
missing spaces in square braces [ ... ]
MeastroZI
reviewed
Nov 28, 2024
| var values = []; | ||
| var value; | ||
| var ctor = factory( 'float64' ); | ||
| var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0, 5.0] ); |
There was a problem hiding this comment.
missing spaces in square braces [ ... ]
| values.push( value ); | ||
| } | ||
|
|
||
| t.deepEqual( values, [1.0, 2.0, 3.0, 4.0, 5.0], 'correctly iterates over values' ); |
There was a problem hiding this comment.
missing spaces in square braces [ ... ] .
please do same for all
|
@MeastroZI Thanks for the review , i have made the required changes. |
Planeshifter
changed the title
values method to array/fixed-endian-factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
values()method was added to the typed array prototype to allow iteration over the array's values. This method returns an iterator, which can be used in afor...ofloop or withnext()calls to access each value in the array sequentially. This change simplifies the process of iterating over typed arrays, ensuring that code interacting with them is more readable and easier to maintain.Fixes: #3161
Resolves #3161
Description
This pull request:
add values method to @stdlib/array/fixed-endian-factory
Related Issues
This pull request:
valuesmethod toarray/fixed-endian-factory#3161Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers