-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix show/hide password on Android #12536
Conversation
Jenkins Builds
|
93% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (65)Click to expand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls do not merge, i'll make review tomorrow, thanks
@@ -64,6 +64,7 @@ | |||
[quo/text-input | |||
{:show-cancel false | |||
:auto-correct false | |||
:keyboard-type "visible-password" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to use keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"visibile-password" appears in the code in other places too as string so I kept it this way, but I can change it everywhere in the code
60% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (3)Click to expand
|
Tested with Android 11 and Android 9 and iOS 14, - seed phrase field does not have autosuggestions (and autocomplete panel) enabled, password fields hide/show also works. |
100% of end-end tests have passed
Passed tests (2)Click to expand
|
- make hide/show password work on Android Signed-off-by: Michele Balistreri <michele@bitgamma.com>
Fixes #11955.
This PR actually has three parts
As a side effect of point 2, when the password is shown, the "suggestions" from SwiftKey and probably other keyboard as activated. This is because I had to make a sort of workaround until facebook/react-native#27946 is fixed. Point 3 seems to at least (from my limited testing) avoid that the password is stored by the keyboard.