Jenkins Builds

✔️ status-react/prs/ios/PR-12427#9 🔹 ~16 min 🔹 e57bd53 🔹 📦 ios package

@briansztamfater can you please rebase it? Thanks

Sure, rebase done @qoqobolo

Thanks, @briansztamfater!
Is it expected that there is no profile image in PN on the group invite?
I believe we could add profile images to this type of PNs ass well, because 3-random name of admin is displayed there. WDYT?

99% of end-end tests have passed

Total executed tests: 67
Failed tests: 1
Passed tests: 66

IDs of failed tests: 3994 

Failed tests (1)

Passed tests (66)

@qoqobolo I agree, that would be a nice addition. Updated PR with that change :)

@briansztamfater PNs on group chat invites are not received in the latest build (0affff5) 👀

@briansztamfater PNs on group chat invites are not received in the latest build (0affff5) 👀

@qoqobolo Hmm interesting, worked on my local build but didn't work on the PR apk. I'll dive into the problem and come back to you with previous deep testing. Sorry about that!

@qoqobolo diving deeper into notifications UX, it seems that default behavior is to show icons on the right side since Android Lollipop, unless it is a conversation. As this is just an invite to a group and not an initiated chat / conversation, maybe it is ok to show it on the right side.

What do you think?

(Also, if you are OK with that, PR is ready to test)

@briansztamfater
It doesn't seem so important to me, as I don't think it is too often the situation when you have several PNs to notice the difference.
However, we can fix it later.
@hesterbruikman better to know your opinion about that.

@briansztamfater to make sure I understand the issue:

• Is the notification only treated differently when it's a group chat invite?
• Do I understand correctly that because the notification is treated differently it can be shown with either no profile image or profile image on the right?
• What happens when a user receives 2 group chat invites from different people at the same time? This makes me think that it's probably better to leave profile image out of group chat invites altogether

Agree with @churik that in any case this would be an uncommon scenario. I do want to understand the issue a bit better though; The scenario might be more common on first time use. You join a community and get invited to a bunch of group chats by members

@briansztamfater to make sure I understand the issue:

• Is the notification only treated differently when it's a group chat invite?
• Do I understand correctly that because the notification is treated differently it can be shown with either no profile image or profile image on the right?
• What happens when a user receives 2 group chat invites from different people at the same time? This makes me think that it's probably better to leave profile image out of group chat invites altogether

Agree with @churik that in any case this would be an uncommon scenario. I do want to understand the issue a bit better though; The scenario might be more common on first time use. You join a community and get invited to a bunch of group chats by members

@hesterbruikman thanks for your time, really appreciate your questions.

• Exactly, but in reality, the conversation notifications are those treated differently, as the default behavior is to have the icon on the right since Android Lollipop.
• Correct, we can show the notification with no profile image on the right, or with no profile image at all (that's how it is currently working in develop branch)
• In that case user should receive two different notifications with different profile pictures at the right (if we decide to show them)

@briansztamfater

ISSUE 3: In the latest build d2f80b7 group invites from contacts are sent to the Activity center

Steps:

1. UserA and UserB add to contacts each other
2. UserA creates a group chat with UserB

Expected result: the group chat to which the user was invited by his contact is displayed on the home screen
Actual result: the group chat is displayed in the Activity center

@qoqobolo seems I also need to rebase status-go part due to some contacts logic modification, on it right now

@qoqobolo Done. Profile image is still showing on group invite notifications, so I'll stay tuned on whether we should remove it or not

@briansztamfater let's keep it as it is, with the profile image on the right, it looks good!
Also, tested the case with 2 group chat invites from different users and can confirm that in that case user receives two different notifications with different profile pictures at the right.

Everything works fine now, thanks for the great work!
PR can be merged.