Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add remote notifications preferences #13129

Merged
merged 2 commits into from
Feb 28, 2022
Merged

add remote notifications preferences #13129

merged 2 commits into from
Feb 28, 2022

Conversation

Parveshdhull
Copy link
Member

fixes #13127

@Parveshdhull Parveshdhull self-assigned this Feb 23, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Feb 23, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6ef84e8 #1 2022-02-23 13:24:30 ~8 min android-e2e 📦apk 📲
✔️ 6ef84e8 #1 2022-02-23 13:24:35 ~8 min android 📦apk 📲
✔️ 6ef84e8 #1 2022-02-23 13:27:20 ~11 min ios 📦ipa 📲
✔️ 42c9975 #2 2022-02-25 17:38:27 ~8 min android-e2e 📦apk 📲
✔️ 42c9975 #2 2022-02-25 17:38:27 ~8 min android 📦apk 📲
✔️ 42c9975 #2 2022-02-25 17:42:12 ~12 min ios 📦ipa 📲

@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 80
Failed tests: 2
Passed tests: 78

IDs of failed tests: 6253,6263

Failed tests (2)

Click to expand
  • Rerun tests

    • 1. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Expected amount of confirmations is 6, in fact 8
    Device 1: Find 'Button' by 'xpath': `//*[contains(@text, "You sent 0.002314418 ETH")]`

    Device 1: Button by xpath: `//*[contains(@text, "You sent 0.002314418 ETH")]` is not found on the screen

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="STT"]`

    Device 1: Button by xpath: `//*[@text="STT"]` is not found on the screen

    Device sessions

    Passed tests (78)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    3. test_wallet_manage_assets, id: 700758
    Device sessions

    4. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    5. test_public_mark_all_messages_as_read, id: 6270
    Device sessions

    6. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    7. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    8. test_group_leave_relogin, id: 3997
    Device sessions

    9. test_send_tx_token_7_decimals, id: 700764
    Device sessions

    10. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    11. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    12. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    13. test_public_delete_chat_long_press, id: 5319
    Device sessions

    14. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    15. test_public_tag_message, id: 700738
    Device sessions

    16. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    17. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    18. test_keycard_fetching_balance_after_offline, id: 6237
    Device sessions

    19. test_send_tx_set_recipient_options_invalid_password, id: 700757
    Device sessions

    20. test_recover_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    21. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    22. test_public_message_edit, id: 700734
    Device sessions

    23. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    24. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    25. test_public_link_send_open, id: 700736
    Device sessions

    26. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    27. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    28. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    29. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    30. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    31. test_public_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    32. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    33. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    34. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    35. test_block_user_from_public_chat, id: 5786
    Device sessions

    36. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    37. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    38. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    39. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    40. test_browser_managing_bookmarks, id: 6633
    Device sessions

    41. test_group_add_new_member_activity_centre, id: 700732
    Device sessions

    42. test_public_fetch_more_history, id: 5675
    Device sessions

    43. test_onboarding_share_contact_address, id: 700743
    Device sessions

    44. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    45. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    46. test_send_tx_custom_token_18_decimals, id: 700765
    Device sessions

    47. test_recover_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    48. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    49. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    50. test_request_stt_from_dapp, id: 5309
    Device sessions

    51. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    52. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    53. test_set_profile_picture, id: 6646
    Device sessions

    54. test_delete_close_all_tabs, id: 5390
    Device sessions

    55. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    56. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    57. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    58. test_group_offline_pn, id: 3998
    Device sessions

    59. test_public_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    60. test_recover_validation_seed_phrase_field, id: 700750
    Device sessions

    61. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    62. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    63. test_dapps_permissions, id: 5738
    Device sessions

    64. test_group_pn_system_messages_when_invited, id: 3994
    Device sessions

    65. test_group_decline_invite_chat_highligted, id: 5756
    Device sessions

    66. test_public_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    67. test_public_unread_messages_counter, id: 5360
    Device sessions

    68. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    69. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    70. test_public_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    71. test_public_message_delete, id: 700735
    Device sessions

    72. test_copy_and_paste_messages, id: 5317
    Device sessions

    73. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    74. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    75. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    76. test_group_join_send_text_messages_pn, id: 700731
    Device sessions

    77. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    78. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    @qoqobolo qoqobolo self-assigned this Feb 25, 2022
    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 2
Failed tests: 2
Passed tests: 0

    IDs of failed tests: 6253,6263

    Failed tests (2)

    Click to expand
  • Rerun tests

    • 1. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    2. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: EditBox element not found
    Device 2: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 2: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    @qoqobolo
    Copy link
    Contributor

    @Parveshdhull thank you for this quick fix!
    No issues found so far, but I have 2 questions

    1. Can we have all options in the Notifications preferences inactive (greyed out) until local or remote notifications are enabled?
    I mean to me as a user, it really doesn't seem very intuitive why I can't enable toggles Notifications from non-contacts and Show @ mentions even though they look the same as toggles Local notifications and Remote notifications.

    video_2022-02-25_17-57-31.mp4

    So probably it would be expected if we had inactive:

    • Notifications from non-contacts, Show @ mentions and Wallet transactions - by default (both PN types are disabled)
    • Notifications from non-contacts and Show @ mentions - with Local notifications enabled (since they only work with Remote notifications)

    2. Is this expected that I cannot enable Wallet transactions with Remote notifications enabled on Android?
    On iOS it's possible to enable Wallet transactions PNs.

    video_2022-02-25_18-08-16.mp4

    @Parveshdhull
    Copy link
    Member Author

    @qoqobolo, Thanks for testing the PR.

    1. Yes, that's great idea, we should disable those options. let me change this 👍
    2. Yes, this is not supported yet, checkout this issue

    @Parveshdhull
    Copy link
    Member Author

    Parveshdhull commented Feb 25, 2022 •
    edited
    Loading

    Please let me know if this looks ok? (also for ios)

    @status-im-auto
    Copy link
    Member

    84% of end-end tests have passed

    Total executed tests: 155
Failed tests: 25
Passed tests: 130

    IDs of failed tests: 5762,5784,6330,700768,6279,6253,700702,6645,6294,700769,6267,6295,6257,6263,6311,5756,700767,695842,6293,695845,6310,6265,695855,6636,5342

    Failed tests (25)

    Click to expand
  • Rerun tests

    • 1. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Find 'Button' by 'xpath': `//*[@text="Sync all devices"]`
    Device 1: Tap on found: Button

    Device 1: Button by xpath:`//*[@text="Sync all devices"]` is not found on the screen

    Device sessions

    2. test_sign_typed_message_deploy_simple_contract_request_pub_key_from_dapp, id: 5784

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    3. test_can_send_all_tokens_via_max_option, id: 6330

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    4. test_keycard_relogin_after_restore, id: 700768

    Device 1: Button element not found
    Device 1: Find 'Text' by 'accessibility id': `default-username`

    Device 1: Text by accessibility id: `default-username` is not found on the screen

    Device sessions

    5. test_send_eth_to_ens_in_chat, id: 6279

    Device 1: Tap on found: Button
    Device 1: Find 'Button' by 'xpath': `//*[@text="Okay, got it"]`

    Device 1: Button by xpath: `//*[@text="Okay, got it"]` is not found on the screen

    Device sessions

    6. test_send_eth_in_1_1_chat_transaction_push, id: 6253

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    7. test_backup_of_contacts, id: 700702

    Device 1: Find 'Button' by 'accessibility id': `contacts-button`
    Device 1: Tap on found: Button

    Device 1: Contact was not backed up!

    Device sessions

    8. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    9. test_keycard_request_and_receive_stt_in_1_1_chat_offline_opened_from_push, id: 6294

    Device 2: SilentButton element not found
    Device 2: Enter default pin 111111

    Device 2: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    10. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

    Device 1: Double tap on: HomeButton
    Device 1: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    11. test_open_user_profile_long_press_on_message, id: 6267

    Device 1: Long press on 'ChatElementByText'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`member-photo` is not found on the screen

    Device sessions

    12. test_keycard_send_eth_to_ens, id: 6295

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    13. test_network_mismatch_for_send_request_in_1_1_chat, id: 6257

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    14. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263

    Device 2: EditBox element not found
    Device 2: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 2: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    15. test_same_seed_added_inside_multiaccount_and_keycard, id: 6311

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    16. test_group_decline_invite_chat_highligted, id: 5756

    Device 2: Looking for chat: 'for_invited'
    Device 2: Wait for element 'Button' for max 30s and click when it is available

    Device 2: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    17. test_keycard_send_tx_eth, id: 700767

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    18. test_creating_community_accept_membership, id: 695842

    Device 2: Wait for 'EditBox'
    ## Public chat 'tvspkjt' is created successfully!

    Device 2: Button by xpath: `//*[@text="some name"]` is not found on the screen

    Device sessions

    19. test_keycard_send_eth_in_1_1_chat, id: 6293

    Device 1: Find 'Button' by 'accessibility id': `send-transaction-bottom-sheet`
    Device 1: Tap on found: Button

    Device 1: No message is shown after sending ETH in 1-1 chat for sender

    Device sessions

    20. test_notification_in_activity_center_for_mention_in_community_and_group_chat, id: 695845

    Device 1: Find 'BackButton' by 'accessibility id': `Navigate Up`
    # STEP: Tapping on community link and request membership

    Device 2: Button by xpath: `//*[@text="some name"]` is not found on the screen

    Device sessions

    21. test_keycard_sign_typed_message_deploy_simple_contract, id: 6310

    Device 1: SilentButton element not found
    Device 1: Enter default pin 111111

    Device 1: 'SilentButton' by accessibility id:'numpad-button-1' not found on the screen

    Device sessions

    22. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 2: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`
    Device 2: Click until 'EditBox' by 'accessibility id': `chat-message-input` will be presented

    Device 2: DeclineTransaction by xpath: `//*[starts-with(@text,'↓ Incoming transaction')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@text="Decline"]` is not found on the screen

    Device sessions

    23. test_custom_gas_settings, id: 695855

    Device 1: Tap on found: Button
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by xpath:`//*[@text="Okay, got it"]` is not found on the screen

    Device sessions

    24. test_show_profile_picture_of_setting_online_indicator, id: 6636

    Device 2: Looking for chat: 'Shocking Violet Salamander'
    Device 2: Find 'ChatImage' by 'xpath': `//*[@content-desc='chat-icon']`

    Profile picture was not updated in 1-1 chat mentions list Profile picture was not updated on user Profile view

    Device sessions

    25. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342

    Device 1: EditBox element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    Passed tests (130)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_wallet_manage_assets, id: 700758
    Device sessions

    3. test_activity_center_group_chats_trusted_contacts, id: 695771
    Device sessions

    4. test_unread_messages_counter_preview_highlited_1_1_chat, id: 5362
    Device sessions

    5. test_keycard_send_funds_between_accounts_set_max_in_multiaccount_instance, id: 6292
    Device sessions

    6. test_can_scan_qr_with_chat_key_from_home_start_chat, id: 6298
    Device sessions

    7. test_resolve_ipns_name, id: 6323
    Device sessions

    8. test_can_pin_messages_in_one_to_one_and_group_chats, id: 695847
    Device sessions

    9. test_keycard_interruption_creating_onboarding_flow, id: 5742
    Device sessions

    10. test_public_mark_all_messages_as_read, id: 6270
    Device sessions

    11. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    12. test_group_leave_relogin, id: 3997
    Device sessions

    13. test_gap_in_public_chat, id: 700727
    Device sessions

    14. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    15. test_keycard_interruption_access_key_onboarding_flow, id: 6246
    Device sessions

    16. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    17. test_keycard_settings_pin_puk_pairing, id: 695841
    Device sessions

    18. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    19. test_public_delete_chat_long_press, id: 5319
    Device sessions

    20. test_block_and_unblock_user_from_group_chat_via_group_info, id: 5752
    Device sessions

    21. test_public_tag_message, id: 700738
    Device sessions

    22. test_can_scan_different_links_with_universal_qr_scanner, id: 6322
    Device sessions

    23. test_keycard_can_recover_keycard_account_offline_and_add_watch_only_acc, id: 6243
    Device sessions

    24. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    25. test_add_remove_contact_via_contacts_view, id: 6312
    Device sessions

    26. test_block_user_from_one_to_one_header_check_push_notification_service, id: 5763
    Device sessions

    27. test_privacy_policy_terms_of_use_node_version_need_help_in_profile, id: 5453
    Device sessions

    28. test_public_clear_history_via_options_and_long_press, id: 5426
    Device sessions

    29. test_pair_devices_sync_photo_community_group_chats, id: 695856
    Device sessions

    30. test_recover_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    31. test_can_use_another_fleets_and_networks_advanced_set_nonce, id: 695890
    Device sessions

    32. test_use_pinned_mailserver, id: 5766
    Device sessions

    33. test_public_message_edit, id: 700734
    Device sessions

    34. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    35. test_public_link_send_open, id: 700736
    Device sessions

    36. test_markdown_support_in_messages, id: 5425
    Device sessions

    37. test_remove_member_from_group_chat, id: 4001
    Device sessions

    38. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    39. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 5781
    Device sessions

    40. test_validation_amount_errors, id: 5437
    Device sessions

    41. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    42. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    43. test_custom_bootnodes, id: 5432
    Device sessions

    44. test_edit_delete_message_in_one_to_one_, id: 695843
    Device sessions

    45. test_public_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    46. test_open_user_profile_using_deep_link, id: 5441
    Device sessions

    47. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    48. test_send_and_open_emoji_link_in_one_to_one, id: 5373
    Device sessions

    49. test_make_admin_member_of_group_chat, id: 5694
    Device sessions

    50. test_backup_recovery_phrase_warning_from_wallet, id: 5358
    Device sessions

    51. test_webview_camera_permission, id: 6635
    Device sessions

    52. test_deny_access_camera_and_gallery, id: 6319
    Device sessions

    53. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    54. test_can_not_connect_to_mailserver, id: 5767
    Device sessions

    55. test_block_user_from_public_chat, id: 5786
    Device sessions

    56. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    57. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_can_scan_eip_681_links, id: 6282
    Device sessions

    60. test_invite_to_group_chat_handling, id: 6324
    Device sessions

    61. test_browser_managing_bookmarks, id: 6633
    Device sessions

    62. test_change_log_level_and_fleet, id: 5368
    Device sessions

    63. test_group_add_new_member_activity_centre, id: 700732
    Device sessions

    64. test_public_fetch_more_history, id: 5675
    Device sessions

    65. test_send_funds_between_accounts_in_multiaccount_instance, id: 6225
    Device sessions

    66. test_onboarding_share_contact_address, id: 700743
    Device sessions

    67. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    68. test_wallet_tx_history_copy_tx_hash_on_lte, id: 700756
    Device sessions

    69. test_disable_use_history_node, id: 6332
    Device sessions

    70. test_reply_to_message_in_chats, id: 6233
    Device sessions

    71. test_open_dapp_using_deep_link, id: 5442
    Device sessions

    72. test_recover_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    73. test_invite_friends, id: 5433
    Device sessions

    74. test_add_switch_delete_custom_mailserver, id: 5436
    Device sessions

    75. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    76. test_different_status_in_timeline, id: 6342
    Device sessions

    77. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    78. test_rename_group_chat, id: 6280
    Device sessions

    79. test_can_reset_password, id: 695850
    Device sessions

    80. test_request_stt_from_dapp, id: 5309
    Device sessions

    81. test_can_delete_several_multiaccounts, id: 6318
    Device sessions

    82. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    83. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395
    Device sessions

    84. test_add_custom_network, id: 5431
    Device sessions

    85. test_switching_accounts_in_dapp, id: 6232
    Device sessions

    86. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    87. test_set_profile_picture, id: 6646
    Device sessions

    88. test_nicknames_ens_group_chats, id: 6327
    Device sessions

    89. test_delete_close_all_tabs, id: 5390
    Device sessions

    90. test_can_change_account_settings, id: 6235
    Device sessions

    91. test_public_unread_messages_counter_for_mentions_relogin, id: 700718
    Device sessions

    92. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    93. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    94. test_push_notifications_reactions_for_messages_in_stickers_audio_image, id: 6321
    Device sessions

    95. test_offline_can_login_cant_send_transaction, id: 5407
    Device sessions

    96. test_keycard_blocked_card_lost_or_frozen_flows, id: 695852
    Device sessions

    97. test_mention_users_not_in_chats_if_not_in_contacts, id: 6326
    Device sessions

    98. test_group_offline_pn, id: 3998
    Device sessions

    99. test_open_url_with_non_english_text_connect_revoke_wallet_new_tab_open_chat_options, id: 5424
    Device sessions

    100. test_public_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    101. test_recover_validation_seed_phrase_field, id: 700750
    Device sessions

    102. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    103. test_app_on_background_by_back_button, id: 6221
    Device sessions

    104. test_recover_accounts_with_certain_seedphrase, id: 5455
    Device sessions

    105. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    106. test_set_currency, id: 5429
    Device sessions

    107. test_can_accept_or_reject_multiple_chats_from_activity_center, id: 695782
    Device sessions

    108. test_dapps_permissions, id: 5738
    Device sessions

    109. test_share_user_profile_url_public_chat, id: 5498
    Device sessions

    110. test_group_pn_system_messages_when_invited, id: 3994
    Device sessions

    111. test_search_chat_on_home, id: 5757
    Device sessions

    112. test_public_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    113. test_search_asset_and_currency, id: 6269
    Device sessions

    114. test_public_unread_messages_counter, id: 5360
    Device sessions

    115. test_keycard_frozen_card_flows, id: 695851
    Device sessions

    116. test_cant_add_more_twenty_participants_to_group_chat, id: 5721
    Device sessions

    117. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    118. test_public_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    119. test_public_message_delete, id: 700735
    Device sessions

    120. test_copy_and_paste_messages, id: 5317
    Device sessions

    121. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    122. test_set_primary_ens_custom_domain, id: 6219
    Device sessions

    123. test_pair_devices_group_chat_different_messages_nicknames, id: 6317
    Device sessions

    124. test_unblocked_user_is_not_added_in_contacts, id: 6213
    Device sessions

    125. test_can_access_images_by_link, id: 5456
    Device sessions

    126. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    127. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    128. test_delete_cut_and_paste_messages, id: 5322
    Device sessions

    129. test_group_join_send_text_messages_pn, id: 700731
    Device sessions

    130. test_can_start_chat_from_suggestions_using_search_chat, id: 6320
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    @Parveshdhull thank you! Looks and works great.
    E2e failures are not PR-related. PR can be merged.

    @Parveshdhull Parveshdhull merged commit 5fd7e35 into develop Feb 28, 2022
    @Parveshdhull Parveshdhull deleted the fix/non-contact-pns branch February 28, 2022 19:59
    jo-mut pushed a commit that referenced this pull request Mar 14, 2022
    @Parveshdhull @jo-mut
    add remote notifications preferences (#13129)
    a4d0060
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @rasom rasom Awaiting requested review from rasom

    Assignees

    @Parveshdhull Parveshdhull

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Push notifications are received for 1-1 messages in Activity center with remote PNs enabled (Android)
    4 participants
    @Parveshdhull @status-im-auto @qoqobolo @flexsurfer