-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ens resolve issue while following deep link #13080
Conversation
Jenkins BuildsClick to see older builds (6)
|
6731877
to
1e03755
Compare
94% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (78)Click to expand
|
Hi @pavloburykh, Thanks for testing the PR, |
@Parveshdhull oh sorry, my comment with issues description was not saved for some reason. ISSUE 1 (Reproducible on Mainnet)ENS username is not shown on Profile page after scanning QR code containing ENS with internal domain stateofus.eth. For reproduction use Mainnet. STR:
Actual result: after Profile page is opened ENS name is displayed for a second, but after that it is changed for 3 random name. telegram-cloud-document-2-5192676311960655242.mp4OS: Android / IOS ISSUE 2 (reproducible both on ropsten and mainnet)ENS name is not resolved in chats until user is added to contacts through Profile => Contacts => Add new contact => Scan deeplink QR code STR:
Actual result: 3 random name is displayed in chats. ENS username starts displaying only after adding user to contacts by opening Profile => Contacts => Add new contact => Scan deeplink QR code Expected result: ENS user name should be displayed. telegram-cloud-document-2-5192676311960655323.mp4 |
Hi @pavloburykh, |
98% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (81)Click to expand |
@Parveshdhull Thank you for fixes, great job!
Actual result: 3 random name is displayed OS: IOS/Android telegram-cloud-document-2-5197679966040363976.mp4 |
@pavloburykh , Sorry, I missed this one, there are so many QR scanners 😄, fixed now 👍 |
86% of end-end tests have passed
Failed tests (12)Click to expand
Passed tests (71)Click to expand
|
50% of end-end tests have passed
Failed tests (6)Click to expand
Passed tests (6)Click to expand
|
@Parveshdhull thanx a lot for your work and such quick bugfixing. PR is ready for merge. |
fixes #11248
status: ready